Page MenuHomePhabricator
Differential D8220

[native] Introduce `NativeEditThreadAvatarProvider`
ClosedPublic
Actions

Authored by atul on Jun 14 2023, 1:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 18, 1:23 PM
Unknown Object (File)
Sat, Mar 1, 9:17 PM
Unknown Object (File)
Sat, Mar 1, 9:09 PM
Unknown Object (File)
Feb 16 2025, 2:39 PM
Unknown Object (File)
Feb 16 2025, 2:39 PM
Unknown Object (File)
Feb 13 2025, 11:43 AM
Unknown Object (File)
Feb 13 2025, 11:43 AM
Unknown Object (File)
Jan 30 2025, 7:00 PM
View All 90 Files
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
Commits
rCOMMa6718f88cc97: [native] Introduce `NativeEditThreadAvatarProvider`
Summary

Slightly different than what we did with NativeEditUserAvatarProvider. In that case we just needed to pass in platform-specific functions which we could do from root.js.

However, in EditThreadAvatarProvider we use NavContext in order to get the activeThreadID. Introduced NativeEditThreadAvatarProvider to get activeThreadID and pass it to EditThreadAvatarProvider.

In next diff will rename EditThreadAvatarProvider to BaseEditThreadAvatarProvider and will move to lib.

Depends on D8219

Test Plan

Things are still working as expected w/ setting thread avatars.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

Diff 27793

View Options

native/avatars/edit-thread-avatar-provider.react.js

div.membersContainer {
display: flex;
flex-direction: column;
overflow: hidden;
margin: 16px;
}
div.membersList { div.membersList {
overflow: scroll; overflow: scroll;
padding: 8px 0; padding: 8px 0;
color: var(--members-modal-member-text); color: var(--members-modal-member-text);
} }
div.noScroll { div.noScroll {
overflow: hidden; overflow: hidden;
Show All 38 Lines
View Options

native/avatars/native-edit-thread-avatar-provider.react.js

div.membersContainer {
display: flex;
flex-direction: column;
overflow: hidden;
margin: 16px;
}
div.membersList { div.membersList {
overflow: scroll; overflow: scroll;
padding: 8px 0; padding: 8px 0;
color: var(--members-modal-member-text); color: var(--members-modal-member-text);
} }
div.noScroll { div.noScroll {
overflow: hidden; overflow: hidden;
Show All 38 Lines
View Options

native/root.react.js

div.membersContainer {
display: flex;
flex-direction: column;
overflow: hidden;
margin: 16px;
}
div.membersList { div.membersList {
overflow: scroll; overflow: scroll;
padding: 8px 0; padding: 8px 0;
color: var(--members-modal-member-text); color: var(--members-modal-member-text);
} }
div.noScroll { div.noScroll {
overflow: hidden; overflow: hidden;
Show All 38 Lines