Page MenuHomePhabricator

[native] Introduce `NativeEditThreadAvatarProvider`
ClosedPublic

Authored by atul on Jun 14 2023, 1:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 2:34 PM
Unknown Object (File)
Sat, Dec 7, 12:38 PM
Unknown Object (File)
Sat, Dec 7, 12:38 PM
Unknown Object (File)
Sat, Dec 7, 12:24 PM
Unknown Object (File)
Nov 21 2024, 10:26 AM
Unknown Object (File)
Nov 21 2024, 10:25 AM
Unknown Object (File)
Nov 21 2024, 10:18 AM
Unknown Object (File)
Oct 26 2024, 8:14 PM
Subscribers

Details

Summary

Slightly different than what we did with NativeEditUserAvatarProvider. In that case we just needed to pass in platform-specific functions which we could do from root.js.

However, in EditThreadAvatarProvider we use NavContext in order to get the activeThreadID. Introduced NativeEditThreadAvatarProvider to get activeThreadID and pass it to EditThreadAvatarProvider.

In next diff will rename EditThreadAvatarProvider to BaseEditThreadAvatarProvider and will move to lib.


Depends on D8219

Test Plan

Things are still working as expected w/ setting thread avatars.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage