Page MenuHomePhabricator

[native] Pull `selectFromGallery`/`useUploadSelectedMedia` out from `EditUserAvatarProvider`
ClosedPublic

Authored by atul on Jun 14 2023, 11:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 26, 12:20 PM
Unknown Object (File)
Thu, Sep 26, 12:20 PM
Unknown Object (File)
Tue, Sep 24, 4:15 AM
Unknown Object (File)
Mon, Sep 16, 2:52 AM
Unknown Object (File)
Mon, Sep 16, 2:52 AM
Unknown Object (File)
Mon, Sep 16, 2:51 AM
Unknown Object (File)
Mon, Sep 16, 2:41 AM
Unknown Object (File)
Aug 29 2024, 8:28 PM
Subscribers

Details

Summary

As part of making EditUserAvatarProvider "platform-agnostic" so it can be used across web and native, we're pulling selectFromGallery and useUploadSelectedMedia out of EditUserAvatarProvider.


Depends on D8213

Test Plan

Made sure I could still successfully select/upload image avatar from native.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul published this revision for review.Jun 14 2023, 11:55 AM
atul added inline comments.
native/root.react.js
279–281 ↗(On Diff #27785)

Realize that these props are cluttering up root.react.js for now.

Once EditUserAvatarProvider is fully "platform-agnostic," I'll move it to lib and create a "wrapping" component for native that will pass in these props.

This revision is now accepted and ready to land.Jun 14 2023, 12:20 PM