Page MenuHomePhabricator
Differential D8215

[native] Pull `selectFromGallery`/`useUploadSelectedMedia` out from `EditUserAvatarProvider`
ClosedPublic
Actions

Authored by atul on Jun 14 2023, 11:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 3, 10:46 PM
Unknown Object (File)
Mar 1 2025, 9:17 PM
Unknown Object (File)
Mar 1 2025, 9:09 PM
Unknown Object (File)
Feb 24 2025, 1:14 PM
Unknown Object (File)
Feb 14 2025, 1:01 PM
Unknown Object (File)
Feb 14 2025, 7:13 AM
Unknown Object (File)
Feb 13 2025, 6:35 AM
Unknown Object (File)
Feb 11 2025, 1:45 PM
View All Files
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
Commits
rCOMM87fb641250c7: [native] Pull `selectFromGallery`/`useUploadSelectedMedia` out from…
Summary

As part of making EditUserAvatarProvider "platform-agnostic" so it can be used across web and native, we're pulling selectFromGallery and useUploadSelectedMedia out of EditUserAvatarProvider.

Depends on D8213

Test Plan

Made sure I could still successfully select/upload image avatar from native.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Jun 14 2023, 11:53 AM
Herald added a subscriber: tomek. · View Herald TranscriptJun 14 2023, 11:53 AM
atul published this revision for review.Jun 14 2023, 11:55 AM
atul added inline comments.
native/root.react.js
279–281

Realize that these props are cluttering up root.react.js for now.

Once EditUserAvatarProvider is fully "platform-agnostic," I'll move it to lib and create a "wrapping" component for native that will pass in these props.

atul added a child revision: D8216: [lib] Move newly platform-agnostic `EditUserAvatarProvider` to `lib`.Jun 14 2023, 12:08 PM
atul mentioned this in D8213: [native] Pull `displayFailureAlert` out of `EditUserAvatarProvider`.Jun 14 2023, 12:17 PM
Harbormaster completed remote builds in B20270: Diff 27785.Jun 14 2023, 12:18 PM
ginsu accepted this revision.Jun 14 2023, 12:20 PM
This revision is now accepted and ready to land.Jun 14 2023, 12:20 PM
atul mentioned this in D8219: [native] Pull `selectFromGallery`/`useUploadSelectedMedia` out from `EditThreadAvatarProvider`.Jun 14 2023, 1:05 PM
Closed by commit rCOMM87fb641250c7: [native] Pull `selectFromGallery`/`useUploadSelectedMedia` out from… (authored by atul). · Explain WhyJun 14 2023, 2:22 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM87fb641250c7: [native] Pull `selectFromGallery`/`useUploadSelectedMedia` out from….
atul mentioned this in rCOMM0318bb6e09fe: [native] Pull `selectFromGallery`/`useUploadSelectedMedia` out from….Jun 16 2023, 11:41 AM

Revision Contents
Changeset List

PathSize
native/
avatars/
24 lines
6 lines

Diff 27785

View Options

native/avatars/edit-user-avatar-provider.react.js

Show First 20 Lines • Show All 342 Lines • ▼ Show 20 Lines query.append(SQL`
ORDER BY tw.threadID, tw.time DESC, tw.id DESC ORDER BY tw.threadID, tw.time DESC, tw.id DESC
`); `);
const [result] = await dbQuery(query); const [result] = await dbQuery(query);
const derivedMessages = await fetchDerivedMessages(result, viewer); const derivedMessages = await fetchDerivedMessages(result, viewer);
const messages = await parseMessageSQLResult(result, derivedMessages, viewer); const messages = await parseMessageSQLResult(result, derivedMessages, viewer);
const rawMessageInfos = []; const rawMessageInfos = [];
const threadToMessageCount = new Map(); const threadToMessageCount = new Map<string, number>();
for (const message of messages) { for (const message of messages) {
const { rawMessageInfo } = message; const { rawMessageInfo } = message;
rawMessageInfos.push(rawMessageInfo); rawMessageInfos.push(rawMessageInfo);
const { threadID } = rawMessageInfo; const { threadID } = rawMessageInfo;
const currentCountValue = threadToMessageCount.get(threadID); const currentCountValue = threadToMessageCount.get(threadID);
const currentCount = currentCountValue ? currentCountValue : 0; const currentCount = currentCountValue ? currentCountValue : 0;
threadToMessageCount.set(threadID, currentCount + 1); threadToMessageCount.set(threadID, currentCount + 1);
} }
▲ Show 20 Lines • Show All 479 Lines • ▼ Show 20 Lines SELECT m.id, (
ORDER BY time DESC, id DESC ORDER BY time DESC, id DESC
LIMIT 1 LIMIT 1
) content ) content
FROM messages m FROM messages m
WHERE m.id IN(${messageIDs}) WHERE m.id IN(${messageIDs})
`; `;
const [result] = await dbQuery(latestEditedMessageQuery); const [result] = await dbQuery(latestEditedMessageQuery);
const latestContentByID = new Map(); const latestContentByID = new Map<string, EditMessageContent>();
for (const row of result) { for (const row of result) {
if (!row.content) { if (!row.content) {
continue; continue;
} }
const content = JSON.parse(row.content); const content = JSON.parse(row.content);
latestContentByID.set(row.id.toString(), content); latestContentByID.set(row.id.toString(), content);
} }
▲ Show 20 Lines • Show All 181 Lines • Show Last 20 Lines
View Options

native/root.react.js

Show First 20 Lines • Show All 342 Lines • ▼ Show 20 Lines query.append(SQL`
ORDER BY tw.threadID, tw.time DESC, tw.id DESC ORDER BY tw.threadID, tw.time DESC, tw.id DESC
`); `);
const [result] = await dbQuery(query); const [result] = await dbQuery(query);
const derivedMessages = await fetchDerivedMessages(result, viewer); const derivedMessages = await fetchDerivedMessages(result, viewer);
const messages = await parseMessageSQLResult(result, derivedMessages, viewer); const messages = await parseMessageSQLResult(result, derivedMessages, viewer);
const rawMessageInfos = []; const rawMessageInfos = [];
const threadToMessageCount = new Map(); const threadToMessageCount = new Map<string, number>();
for (const message of messages) { for (const message of messages) {
const { rawMessageInfo } = message; const { rawMessageInfo } = message;
rawMessageInfos.push(rawMessageInfo); rawMessageInfos.push(rawMessageInfo);
const { threadID } = rawMessageInfo; const { threadID } = rawMessageInfo;
const currentCountValue = threadToMessageCount.get(threadID); const currentCountValue = threadToMessageCount.get(threadID);
const currentCount = currentCountValue ? currentCountValue : 0; const currentCount = currentCountValue ? currentCountValue : 0;
threadToMessageCount.set(threadID, currentCount + 1); threadToMessageCount.set(threadID, currentCount + 1);
} }
▲ Show 20 Lines • Show All 479 Lines • ▼ Show 20 Lines SELECT m.id, (
ORDER BY time DESC, id DESC ORDER BY time DESC, id DESC
LIMIT 1 LIMIT 1
) content ) content
FROM messages m FROM messages m
WHERE m.id IN(${messageIDs}) WHERE m.id IN(${messageIDs})
`; `;
const [result] = await dbQuery(latestEditedMessageQuery); const [result] = await dbQuery(latestEditedMessageQuery);
const latestContentByID = new Map(); const latestContentByID = new Map<string, EditMessageContent>();
for (const row of result) { for (const row of result) {
if (!row.content) { if (!row.content) {
continue; continue;
} }
const content = JSON.parse(row.content); const content = JSON.parse(row.content);
latestContentByID.set(row.id.toString(), content); latestContentByID.set(row.id.toString(), content);
} }
▲ Show 20 Lines • Show All 181 Lines • Show Last 20 Lines