Differential D8257
[keyserver] Return blob hash and holder from upload endpoint Authored by bartek on Jun 20 2023, 5:20 AM. Tags None Referenced Files
Subscribers
Details Until now, the blob service upload endpoint (upload-media-metadata) returned the same result as the upload-multimedia endpoint. Depends on D8256 Called the upload-media-metadata endpoint from web input-state-container. Received the following output: 
Diff Detail
Event TimelineComment Actions
Isn't this data already available on the client? If the data comes from the client, then I'm a little confused why we're returning it from the endpoint Comment Actions Yes, it is. I don't know the beginnings of this convention, but we're doing the same with other values like loop, dimensions etc (probably the media could be processed on keyserver and these values could change). Either way, I need to return UploadMediaMetadataResult from blobServiceUpload() in web/input-state-container. Alternatively, I can do it directly from there, just thought it would be cleaner to do it the same way other params are passed Comment Actions
I suspect that these other parameters either can be changed by the keyserver, or (perhaps more likely) at some point we thought we would want to be able to change them on the keyserver.
If we are confident that the keyserver will not change this parameter, then I think we should avoid wasting network traffic on it. My impression is that the keyserver won't be downloading the whole blob anyways, so there's no way to confirm the blob hash (or generate a new one). Comment Actions Blob hash won't be changed on keyserver, and regarding the holder: it's not gonna be changed too, unless we'd like to introduce some holder-manipulation logic in the future (rather unlikely in this case) so I'll do the other approach Comment Actions Decided to go with a client-side approach in D8320 so abandoning this for now. We can always return additional data in the future without breaking if needed. |