[android] Bump `com.facebook.fresco:*` deps to `2.5.0`
ClosedPublic
Actions

Authored by atul on Jun 22 2023, 11:56 AM.

Details

Reviewers

ashoat
ginsu
rohan
bartek

Commits

rCOMM0bc429f52dfd: [android] Bump `com.facebook.fresco:*` deps to `2.5.0`

Summary

Basically it appears that 2.2.0, which we previously specified in build.gradle was removed from all the artifact hosting services. It appears that expo depends on fresco, and the fresco version for Expo SDK 47 is 2.5.0 (see below)... so I'm bumping to that to see

If that resolves CI
If images continue to appear as expected on Android

Test Plan

CI, and trying out some flows on Android that involve images.

Diff Detail

Repository

rCOMM Comm

Branch

arcpatch-D8296 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Jun 22 2023, 11:56 AM

Herald added a subscriber: tomek. · View Herald TranscriptJun 22 2023, 11:56 AM

atul published this revision for review.Jun 22 2023, 12:00 PM

atul edited the summary of this revision. (Show Details)

I wonder if we need fresco as direct dependency... Do we use it anywhere outside expo-image? I think it's some leftovers from old expo.
Expo-image docs don't mention any additional gradle steps: https://github.com/expo/expo/tree/sdk-48/packages/expo-image#installation

Anyway, accepting for now, feel free to either experiment with removing these deps or just land this once Android CI passes

This revision is now accepted and ready to land.Jun 22 2023, 12:07 PM

In D8296#244671, @bartek wrote:

Do we use it anywhere outside expo-image? I think it's some leftovers from old expo.

Never mind, it's still in expo bare app template

But on the other hand, expo-image uses Glide instead of Fresco, however we might still use non-expo react-native <Image /> in some places so this might still be needed

In D8296#244671, @bartek wrote:

I wonder if we need fresco as direct dependency... Do we use it anywhere outside expo-image? I think it's some leftovers from old expo.
Expo-image docs don't mention any additional gradle steps: https://github.com/expo/expo/tree/sdk-48/packages/expo-image#installation

Anyway, accepting for now, feel free to either experiment with removing these deps or just land this once Android CI passes

I saw this PR (https://github.com/expo/expo/pull/22542) which removes the expo-image-loader dependency on com.facebook.fresco, but it landed 3 weeks ago so we'll probably need to wait a bit before we can do the same.

Harbormaster failed remote builds in B20437: Diff 28014!Jun 22 2023, 12:18 PM

land this once Android CI passes

Still need to resolve the "Could not find com.arthenica:mobile-ffmpeg-min-gpl:4.3.1.LTS." issue before CI will pass. I'll leave this diff in accepted state until I resolve that one.

rebase and land

Landing, but @ashoat should take a look when he's back since it's regarding dependencies.

This revision was landed with ongoing or failed builds.Jun 23 2023, 12:29 PM

Closed by commit rCOMM0bc429f52dfd: [android] Bump `com.facebook.fresco:*` deps to `2.5.0` (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM0bc429f52dfd: [android] Bump `com.facebook.fresco:*` deps to `2.5.0`.

Harbormaster completed remote builds in B20477: Diff 28059.Jun 23 2023, 12:30 PM

Dependencies seem fine