[native] Bump `react-native-ffmpeg` to `5.2.0`
AbandonedPublic
Actions

Authored by atul on Jun 22 2023, 8:07 PM.

Details

Reviewers

ashoat
ginsu
rohan
bartek
tomek

Summary

Should resolve issue detailed here: https://linear.app/comm/issue/ENG-4177/address-android-dependency-artifact-issues

Test Plan

I described in the Linear issue how I plan to make sure that there are no issues with this upgrade. I haven't gone through all the steps yet, but will make sure to before landing.

Diff Detail

Repository

rCOMM Comm

Branch

fix-android (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Jun 22 2023, 8:07 PM

Herald added a subscriber: tomek. · View Herald TranscriptJun 22 2023, 8:07 PM

atul published this revision for review.Jun 22 2023, 8:08 PM

remove patch

Harbormaster failed remote builds in B20438: Diff 28015!Jun 22 2023, 8:18 PM

Harbormaster failed remote builds in B20439: Diff 28016!Jun 22 2023, 8:22 PM

atul added a reviewer: tomek.Jun 23 2023, 2:15 PM

Bumping the version looks ok, but it seems to break iOS build

This revision now requires changes to proceed.Jun 23 2023, 2:20 PM

In D8297#244953, @tomek wrote:

Bumping the version looks ok, but it seems to break iOS build

Yeah, think it's with the SDWebImage bump. I did pod update, but there's another command to bump just react-native-ffmpeg. I'll recreate this diff

atul planned changes to this revision.Jun 28 2023, 7:26 PM

atul abandoned this revision.Jul 28 2023, 9:54 PM