Page MenuHomePhabricator
Differential D8322

[lib][keyserver] Rename holder to blobHash where appropriate
ClosedPublic
Actions

Authored by bartek on Jun 26 2023, 9:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 2:23 PM
Unknown Object (File)
Sat, Nov 23, 2:23 PM
Unknown Object (File)
Sat, Nov 23, 1:15 PM
Unknown Object (File)
Sat, Nov 23, 7:07 AM
Unknown Object (File)
Sat, Nov 23, 7:07 AM
Unknown Object (File)
Fri, Nov 22, 9:48 PM
Unknown Object (File)
Tue, Nov 12, 2:10 PM
Unknown Object (File)
Tue, Nov 12, 2:10 AM
View All Files
Subscribers
tomek

Details

Reviewers
atul
ashoat
Commits
rCOMMce7821232c14: [lib][keyserver] Rename holder to blobHash where appropriate
Summary

Part of ENG-3975.
Now the holder name isn't accurate in some places, so I renamed it

Depends on D8321

Test Plan

Flow check

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Jun 26 2023, 9:05 PM
bartek held this revision as a draft.
Herald added a subscriber: tomek. · View Herald TranscriptJun 26 2023, 9:05 PM
bartek added a child revision: D8323: [native] Rename holder prop to blobURI.Jun 26 2023, 9:05 PM
Harbormaster completed remote builds in B20517: Diff 28131.Jun 26 2023, 9:23 PM
bartek retitled this revision from [lib][keyserver] Rename holder to blobHash where possible to [lib][keyserver] Rename holder to blobHash where appropriate.Jun 26 2023, 11:33 PM
bartek edited the summary of this revision. (Show Details)
bartek edited the test plan for this revision. (Show Details)
bartek added a child revision: D8325: [web] Rename multimedia holder to blobURI.Jun 26 2023, 11:43 PM
bartek published this revision for review.Jun 26 2023, 11:47 PM
atul accepted this revision.Jun 28 2023, 12:07 PM

Looks good!

lib/utils/blob-service.js
18–21

Thanks for adding these!

578969.png (418×1 px, 236 KB)

They come up during autocomplete + when hovering over function which is nice.

This revision is now accepted and ready to land.Jun 28 2023, 12:07 PM
atul attached a referenced file: F610896: 578969.png. (Show Details)Jun 28 2023, 12:07 PM
bartek updated this revision to Diff 28226.Jun 28 2023, 1:14 PM

Rebase

Harbormaster completed remote builds in B20589: Diff 28226.Jun 28 2023, 1:46 PM
Closed by commit rCOMMce7821232c14: [lib][keyserver] Rename holder to blobHash where appropriate (authored by bartek). · Explain WhyJun 28 2023, 11:12 PM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMce7821232c14: [lib][keyserver] Rename holder to blobHash where appropriate.

Revision Contents
Changeset List

PathSize
keyserver/
src/
fetchers/
6 lines
lib/
facts/
2 lines
media/
6 lines
utils/
26 lines

Diff 28131

View Options

keyserver/src/fetchers/upload-fetchers.js

Loading...
View Options

lib/facts/blob-service.js

Loading...
View Options

lib/media/media-utils.js

Loading...
View Options

lib/utils/blob-service.js

Loading...