Page MenuHomePhabricator

[lib][native] Disambiguate URIs in media-cache
ClosedPublic

Authored by bartek on Jun 26 2023, 9:06 PM.
Tags
None
Referenced Files
F3374877: D8324.diff
Tue, Nov 26, 5:20 PM
Unknown Object (File)
Sat, Nov 23, 1:15 PM
Unknown Object (File)
Sat, Nov 23, 1:15 PM
Unknown Object (File)
Sat, Nov 23, 7:07 AM
Unknown Object (File)
Sat, Nov 23, 7:07 AM
Unknown Object (File)
Sat, Nov 23, 7:07 AM
Unknown Object (File)
Sat, Nov 23, 3:55 AM
Unknown Object (File)
Sun, Nov 17, 10:03 PM
Subscribers

Details

Summary

Part of ENG-3975.
Now the holder isn't accurate, I decided to name this value blobURI because it is of format: either https://keyserver/uploads/... or blob-service://blob-hash.

For media cache, we have two kind of URIs: blobURI - a cache key, and localURI/mediaURI which is a URI to local multimedia file. I needed to rename these accordingly

In short:

  • holder -> blobURI
  • uri -> mediaURI
  • Added some more comments

Depends on D8323

Test Plan

Flow, also ran the native app, cleared media cache and ensured that encrypted multimedia are still displayed as expected. Also did some debugging to check if they're loading from cache

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek held this revision as a draft.
bartek edited the test plan for this revision. (Show Details)
bartek published this revision for review.Jun 26 2023, 11:47 PM
atul added inline comments.
lib/components/media-cache-provider.react.js
10–16

Thanks for updating comments to reflect your code changes!

(CC @ashoat, @tomek)

This revision is now accepted and ready to land.Jun 28 2023, 12:14 PM