Page MenuHomePhabricator

Move `native`-specific `uploadSelectedMedia` from `updateImageUserAvatar` to `nativeUpdateUserImageAvatar`
ClosedPublic

Authored by atul on Jun 27 2023, 6:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 1, 5:31 PM
Unknown Object (File)
Sun, Oct 27, 10:31 AM
Unknown Object (File)
Sun, Oct 27, 10:31 AM
Unknown Object (File)
Sun, Oct 27, 10:31 AM
Unknown Object (File)
Sun, Oct 27, 10:30 AM
Unknown Object (File)
Sun, Oct 27, 10:13 AM
Unknown Object (File)
Sat, Oct 19, 11:56 AM
Unknown Object (File)
Sep 30 2024, 6:46 AM
Subscribers

Details

Summary

We remove the native-specific uploadSelectedMedia call from updateImageUserAvatar and move it to native-specific nativeUpdateUserImageAvatar.

As of this diff, updateImageUserAvatar now takes (imageAvatarUpdateRequest: ImageAvatarDBContent) rather than the native-specific (selection: NativeMediaSelection).

This diff also eliminates all usages of useUploadSelectedMedia, which means we can remove the prop in a subsequent diff at which point BaseEditUserAvatarProvider will be platform-agnostic! That'll let us consolidate BaseEditUserAvatarProvider, WebEditUserAvatarProvider, and NativeEditUserAvatarProvider.


Depends on D8345

Test Plan

Continue to be able to set image avatars on native as expected.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul published this revision for review.Jun 27 2023, 6:25 PM
This revision is now accepted and ready to land.Jun 28 2023, 10:11 AM
This revision was landed with ongoing or failed builds.Jul 28 2023, 2:04 PM
This revision was automatically updated to reflect the committed changes.