[web/native] Add lastCommunicatedPlatformDetails to redux
ClosedPublic
Actions

Authored by michal on Jun 28 2023, 1:52 AM.

Details

Reviewers

kamil
tomek

Commits

rCOMMc6b1eecb5b5b: [web/native] Add lastCommunicatedPlatformDetails to redux

Summary

https://linear.app/comm/issue/ENG-3905/platform-details-arent-updated-on-http-communication

Currently platform details are only send on web socket intialization and login. This is a problem because before the websocket is connected the client can already communicate with the keyserver with http endpoints. This diff adds lastCommunicatedPlatformDetails to redux which will keep track of the last send platform details, so we can resend them if they change. We track this as map of urlPrefix -> PlatformDetails, in preparation for multi keyservers.

NOTE: for some reason flow throws an error in a few places after adding the new action. To fix this I've added a few no-op casts (the types that I'm casting to, are the types flow infered for these values already).

Test Plan

Test if redux is updated on login. Test if the action works with the next diff

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michal created this revision.Jun 28 2023, 1:52 AM

Herald added a subscriber: ashoat. · View Herald TranscriptJun 28 2023, 1:52 AM

Fix type

Harbormaster failed remote builds in B20568: Diff 28203!Jun 28 2023, 2:03 AM

Harbormaster completed remote builds in B20569: Diff 28204.Jun 28 2023, 2:14 AM

michal requested review of this revision.Jun 28 2023, 2:14 AM

michal added a child revision: D8351: [web/native] Send platform details on http communication.Jun 28 2023, 3:18 AM

LGTM but please address my inline comment

lib/reducers/last-communicated-platform-details-reducer.js
14 ↗	(On Diff #28204)	looks like `logInActionTypes.success` is not enough what about other auth actions: `siweAuthActionTypes.success` `registerActionTypes.success`

This revision is now accepted and ready to land.Jul 4 2023, 2:13 AM

Handle other auth actions

Harbormaster completed remote builds in B20706: Diff 28375.Jul 4 2023, 3:10 AM

ashoat added a subscriber: inka.Jul 4 2023, 5:51 PM

ashoat added inline comments.

lib/reducers/last-communicated-platform-details-reducer.js
17 ↗	(On Diff #28375)	@inka has a task with all of the different Redux properties we need to migrate to multi-keyserver. We should probably add a subtask to migrate this one... the collection is future-proof, but the reducer will need to be updated
34 ↗	(On Diff #28375)	Should we "unset" things on a log out / account deletion / session invalidation?

michal added inline comments.Jul 5 2023, 6:26 AM

lib/reducers/last-communicated-platform-details-reducer.js
34 ↗	(On Diff #28375)	I don't think that's needed. This is a device-wide data, not account specific.

ashoat added inline comments.Jul 5 2023, 10:32 AM

lib/reducers/last-communicated-platform-details-reducer.js
34 ↗	(On Diff #28375)	Is it possible that the keyserver will delete the data when the user logs out? In that case, the data might not be up-to-date on the keyserver, but the client might skip sending it because it thinks it's up-to-date

michal added inline comments.Jul 10 2023, 6:12 AM

lib/reducers/last-communicated-platform-details-reducer.js
34 ↗	(On Diff #28375)	After logging out the anonymous cookie that is created keeps the platform details of the user. Additionally the client will still always send the platform on login, so if for some reason the they get out-of-sync they will synchronise at login.