Paths

Table of Contentst

Differential D8374

[lib][keyserver] Use blobURI based on client version
ClosedPublic
Actions

Authored by bartek on Jun 29 2023, 6:43 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 23, 12:45 PM

	Unknown Object (File)
	Sat, Nov 23, 7:10 AM

	Unknown Object (File)
	Sat, Nov 23, 7:10 AM

	Unknown Object (File)
	Mon, Nov 18, 7:16 PM

	Unknown Object (File)
	Sun, Nov 10, 12:33 PM

	Unknown Object (File)
	Sat, Nov 9, 4:04 AM

	Unknown Object (File)
	Fri, Nov 8, 8:03 AM

	Unknown Object (File)
	Fri, Nov 8, 8:03 AM

Subscribers

Details

Reviewers

ashoat
atul

Commits

rCOMM43fb444900bb: [lib][keyserver] Use blobURI based on client version

Summary

The last part of ENG-3966. Details are described in the comments (regarding pt. 4)

This diff introduces a utility function, that constructs a multimedia message based on client version.

Depends on D8373

Test Plan

CI should finally pass here.

Tested as follows:

Enabled blob service uploads on both web and native
Added some console logs to encryptedMediaBlobURI() to display if there's a holder or blobURI.
On keyserver side, there should always be blobURI.
The same on web (dev console)
On native, there should be old format (holder) when minCodeVersion is set to something not yet released (FUTURE_CODE_VERSION) and use blobURI otherwise.

Also tested the following:

Uploading and displaying encrypted media on Web (both video and images)
Uploading and displaying encrypted media on Native (both video and images)
Displaying thread media gallery media on both web and native

Diff Detail

Repository

Branch

barthap/blob-uri

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Jun 29 2023, 6:43 AM

bartek held this revision as a draft.

Herald added a subscriber: tomek. · View Herald TranscriptJun 29 2023, 6:43 AM

Harbormaster failed remote builds in B20611: Diff 28259!Jun 29 2023, 6:56 AM

Rebase

Harbormaster completed remote builds in B20614: Diff 28262.Jun 29 2023, 7:31 AM

bartek edited the summary of this revision. (Show Details)Jun 29 2023, 8:01 AM

bartek edited the test plan for this revision. (Show Details)

bartek published this revision for review.Jun 29 2023, 8:15 AM

bartek added inline comments.

keyserver/src/fetchers/upload-fetchers.js
142 ↗	(On Diff #28262)	From now on, the final message format is translated based on client version, so we can use the new fields in keyserver utilites

bartek added inline comments.Jun 29 2023, 8:21 AM

lib/media/media-utils.js
143–147 ↗	(On Diff #28262)	Accidentally committed these (part of the test plan), will remove before landing.

ashoat accepted this revision.Jul 2 2023, 3:05 PM

This revision is now accepted and ready to land.Jul 2 2023, 3:05 PM

ashoat mentioned this in D8371: [lib] Workaround Flow issues in messages-reducer.Jul 4 2023, 11:14 AM

Rebase

Harbormaster completed remote builds in B20834: Diff 28521.Jul 10 2023, 2:57 AM

Remove console.log

Harbormaster completed remote builds in B20840: Diff 28529.Jul 10 2023, 4:08 AM

Closed by commit rCOMM43fb444900bb: [lib][keyserver] Use blobURI based on client version (authored by bartek). · Explain WhyJul 11 2023, 2:58 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM43fb444900bb: [lib][keyserver] Use blobURI based on client version.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

fetchers/

upload-fetchers.js

14 lines

lib/

media/

54 lines

shared/

messages/

multimedia-message-spec.js

28 lines

Diff 28529

keyserver/src/fetchers/upload-fetchers.js

Loading...

lib/media/media-utils.js

Loading...

lib/shared/messages/multimedia-message-spec.js

Loading...