Page MenuHomePhabricator
Differential D8396

[blob-service] Require holder and blob_hash in 'remove' endpoint
ClosedPublic
Actions

Authored by bartek on Jun 30 2023, 8:30 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 16, 5:42 AM
Unknown Object (File)
Thu, Jun 13, 9:17 PM
Unknown Object (File)
Wed, Jun 12, 10:21 PM
Unknown Object (File)
Wed, Jun 12, 8:48 PM
Unknown Object (File)
Wed, Jun 12, 5:26 PM
Unknown Object (File)
Tue, Jun 11, 4:25 PM
Unknown Object (File)
Fri, Jun 7, 11:00 PM
Unknown Object (File)
Mon, Jun 3, 8:32 PM
View All 61 Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
• patryk
• jon
marcin
Commits
rCOMM9ef42369669d: [blob-service] Require holder and blob_hash in 'remove' endpoint
Summary

Linear task: ENG-4268.

Made the DELETE /blob HTTP endpoint require both holder and blob_hash parameters.
Also renamed delete_blob to remove_holder because this is what this endpoint actually does. The blob is deleted when the last holder is removed.

Test Plan

Tested together with the next diff

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Jun 30 2023, 8:30 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 30 2023, 8:30 AM
bartek added a child revision: D8397: [web] Update Blob service DELETE endpoint call.Jun 30 2023, 8:34 AM
bartek updated this revision to Diff 28307.Jun 30 2023, 8:46 AM

Fix typo

Harbormaster completed remote builds in B20650: Diff 28304.Jun 30 2023, 8:59 AM
bartek published this revision for review.Jun 30 2023, 9:18 AM
Harbormaster completed remote builds in B20653: Diff 28307.Jun 30 2023, 9:26 AM
• jon accepted this revision.Jun 30 2023, 4:43 PM
michal accepted this revision.Jul 3 2023, 3:50 AM
This revision is now accepted and ready to land.Jul 3 2023, 3:50 AM
bartek updated this revision to Diff 28469.Jul 7 2023, 5:22 AM

Rebase

Harbormaster completed remote builds in B20789: Diff 28469.Jul 7 2023, 5:39 AM
Closed by commit rCOMM9ef42369669d: [blob-service] Require holder and blob_hash in 'remove' endpoint (authored by bartek). · Explain WhyJul 7 2023, 7:00 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM9ef42369669d: [blob-service] Require holder and blob_hash in 'remove' endpoint.

Revision Contents
Changeset List

PathSize
services/
blob/
src/
http/
handlers/
21 lines
6 lines

Diff 28479

View Options

services/blob/src/http/handlers/blob.rs

Loading...
View Options

services/blob/src/http/mod.rs

Loading...