Page MenuHomePhabricator

[lib/native/web] add user edit icon to comm icon pack
ClosedPublic

Authored by ginsu on Jul 10 2023, 12:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Aug 9, 9:44 PM
Unknown Object (File)
Fri, Aug 9, 9:44 PM
Unknown Object (File)
Fri, Aug 9, 9:42 PM
Unknown Object (File)
Jul 12 2024, 5:02 PM
Unknown Object (File)
Jul 12 2024, 5:00 PM
Unknown Object (File)
Jul 12 2024, 1:57 PM
Unknown Object (File)
Jul 4 2024, 12:07 PM
Unknown Object (File)
Jun 30 2024, 4:04 AM
Subscribers

Details

Summary

Added user-edit icon to the comm icons pack. These changes were copy and pasted from Iconmoon. I also added the new icon to our dropbox for an easy visual reference

Test Plan

Please see the screenshots below. (The minor visual differences in web/native (the color/size) are just due to different props being used in the CommIcon component in web vs native. There is no visual difference with the actual icon)

Native:

Screenshot 2023-07-10 at 3.53.31 PM.png (164×182 px, 8 KB)

Web:

Screenshot 2023-07-10 at 3.54.53 PM.png (142×160 px, 7 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, rohan.
ginsu requested review of this revision.Jul 10 2023, 1:17 PM

Looks pretty similar to D8308 and it looks good - thanks!

This revision is now accepted and ready to land.Jul 10 2023, 1:41 PM