Paths

Table of Contentst

Differential D8467

[lib/native/web] add user edit icon to comm icon pack
ClosedPublic
Actions

Authored by ginsu on Jul 10 2023, 12:57 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 23, 12:49 PM

	Unknown Object (File)
	Mon, Nov 11, 7:36 PM

	Unknown Object (File)
	Mon, Nov 11, 5:58 PM

	Unknown Object (File)
	Thu, Nov 7, 5:08 PM

	Unknown Object (File)
	Thu, Nov 7, 11:54 AM

	Unknown Object (File)
	Mon, Oct 28, 10:39 AM

	Unknown Object (File)
	Oct 19 2024, 9:24 AM

	Unknown Object (File)
	Oct 19 2024, 9:23 AM

View All 58 Files

Subscribers

Details

Reviewers

atul
rohan

Commits

rCOMM2b30b991db77: [lib/native/web] add user edit icon to comm icon pack

Summary

Added user-edit icon to the comm icons pack. These changes were copy and pasted from Iconmoon. I also added the new icon to our dropbox for an easy visual reference

Test Plan

Please see the screenshots below. (The minor visual differences in web/native (the color/size) are just due to different props being used in the CommIcon component in web vs native. There is no visual difference with the actual icon)

Native:

Screenshot 2023-07-10 at 3.53.31 PM.png (164×182 px, 8 KB)

Web:

Screenshot 2023-07-10 at 3.54.53 PM.png (142×160 px, 7 KB)

Diff Detail

Repository

Branch

comm-icons-update (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Jul 10 2023, 12:57 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 10 2023, 12:57 PM

ginsu edited the summary of this revision. (Show Details)Jul 10 2023, 12:59 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, rohan.

ginsu attached a referenced file: F630488: Screenshot 2023-07-10 at 3.54.53 PM.png. (Show Details)

ginsu attached a referenced file: F630487: Screenshot 2023-07-10 at 3.53.31 PM.png. (Show Details)

ginsu edited the test plan for this revision. (Show Details)Jul 10 2023, 1:05 PM

Harbormaster completed remote builds in B20853: Diff 28561.Jul 10 2023, 1:17 PM

ginsu requested review of this revision.Jul 10 2023, 1:17 PM

Looks pretty similar to D8308 and it looks good - thanks!

This revision is now accepted and ready to land.Jul 10 2023, 1:41 PM

rebase before landing

Harbormaster completed remote builds in B20877: Diff 28597.Jul 11 2023, 12:24 PM

Closed by commit rCOMM2b30b991db77: [lib/native/web] add user edit icon to comm icon pack (authored by ginsu). · Explain WhyJul 11 2023, 1:05 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM2b30b991db77: [lib/native/web] add user edit icon to comm icon pack.

Revision Contents
Changeset List

Path

Size

lib/

shared/

comm-icon-config.json

95 lines

native/

fonts/

web/

CommIcon.react.js

3 lines

Diff 28597

lib/shared/comm-icon-config.json

Loading...

native/fonts/CommIcons.ttf

Loading...

web/CommIcon.react.js

Loading...