[lib] Create generic cookies selector
ClosedPublic
Actions

Authored by inka on Jul 18 2023, 12:50 PM.

Details

Reviewers

michal
kamil

Commits

rCOMM9f31bdc2d87f: [lib] Create generic cookies selector

Summary

https://linear.app/comm/issue/ENG-4377/refactor-cookie-field-in-web-redux
Creating a selector that will return a map of all cookies keyed by keyservers ids.

Test Plan

Checked that the selector returns the "map".

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Jul 18 2023, 12:50 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 18 2023, 12:50 PM

inka added a parent revision: D8534: [lib, web, native] Use KesyerverStore to get current cookie.Jul 18 2023, 12:50 PM

inka added a child revision: D8536: [lib, keyserver, native, web] Remove the cookie field from redux.Jul 18 2023, 12:58 PM

Harbormaster completed remote builds in B20997: Diff 28787.Jul 18 2023, 1:10 PM

inka requested review of this revision.Jul 18 2023, 1:10 PM

michal accepted this revision.Jul 19 2023, 6:13 AM

michal added inline comments.

lib/selectors/keyserver-selectors.js
14	Was this supposed to be `keyserverID`?

This revision is now accepted and ready to land.Jul 19 2023, 6:13 AM

Fix variable name

Harbormaster completed remote builds in B21056: Diff 28852.Jul 19 2023, 10:40 AM

Closed by commit rCOMM9f31bdc2d87f: [lib] Create generic cookies selector (authored by inka). · Explain WhyJul 21 2023, 1:55 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMM9f31bdc2d87f: [lib] Create generic cookies selector.

Revision Contents
Changeset List

Path

Size

lib/

selectors/

keyserver-selectors.js

18 lines

Diff 28787

View Options

lib/selectors/keyserver-selectors.js

[lib] Create generic cookies selectorClosedPublicActions