[lib, keyserver, native, web] Remove the cookie field from redux
ClosedPublic
Actions

Authored by inka on Jul 18 2023, 12:57 PM.

Details

Reviewers

michal
kamil

Commits

rCOMM3a16499dcd8e: [lib, keyserver, native, web] Remove the cookie field from redux

Summary

https://linear.app/comm/issue/ENG-4377/refactor-cookie-field-in-web-redux
Removing the cookie field from redux. Adding a migration. Undoing a hack in cookieSelector.

Test Plan

ran yarn flow-all. Since cookie was not being used since the previous diff, this should be enough

EDIT:
tested that the cookie was migrated on native:

checked out master, opened the app, logged the cookie
closed the app
checked out this diff, opened the app, logged the cookie

On master, rehyderated keys included cookie. On this diff, rehydrated keys don't include 'cookie', but include the keyserverStore. Checked that cookie that was logged on master is equal to the keyserverStore.keyserverInfos['256'].cookie on this diff

Diff Detail

Repository

rCOMM Comm

Branch

inka/cookies

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Jul 18 2023, 12:57 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 18 2023, 12:57 PM

inka added a parent revision: D8535: [lib] Create generic cookies selector.Jul 18 2023, 12:58 PM

Cookie on web has to stay undefined

Harbormaster completed remote builds in B20998: Diff 28788.Jul 18 2023, 1:18 PM

Harbormaster completed remote builds in B20999: Diff 28789.Jul 18 2023, 1:25 PM

inka requested review of this revision.Jul 18 2023, 1:25 PM

inka added reviewers: michal, kamil.Jul 19 2023, 2:46 AM

Can you amend the test plan with checking if the cookie was migrated correctly?

native/redux/persist.js
651–658	You need to bump the state version (if you aren't doing it in the next diffs)
web/redux/persist.js
97–104	Is the migration on web needed? (and if yes, you also need to bump the stateVersion)