Paths

Table of Contentst

[native] move `olm/olm.h` include to proper file
ClosedPublic
Actions

Authored by kamil on Jul 31 2023, 3:53 AM.

Details

Reviewers

michal
tomek
• jon
marcin

Commits

rCOMM675661c895f6: [native] move `olm/olm.h` include to proper file

Summary

We do not need this header Tools.h, it's not used here, but it's not included in Session.h where it's needed.

This cause 2 issues:

Required using #ifndef EMSCRIPTEN, because Tools.h is used on web, and we do not want to add olm.h to bundle.
Breaking our C++ coding standards: src.

Test Plan

Build iOS, Android, WASM.

Diff Detail

Repository

rCOMM Comm

Branch

remove-ifdefs

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Jul 31 2023, 3:53 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJul 31 2023, 3:53 AM

Harbormaster completed remote builds in B21359: Diff 29262.Jul 31 2023, 4:17 AM

kamil published this revision for review.Jul 31 2023, 6:07 AM

tomek accepted this revision.Jul 31 2023, 6:08 AM

This revision is now accepted and ready to land.Jul 31 2023, 6:08 AM

Closed by commit rCOMM675661c895f6: [native] move `olm/olm.h` include to proper file (authored by kamil). · Explain WhyAug 1 2023, 4:18 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM675661c895f6: [native] move `olm/olm.h` include to proper file.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

CryptoTools/

Session.h

2 lines

Tools.h

4 lines

Diff 29262

View Options

native/cpp/CommonCpp/CryptoTools/Session.h