[tunnelbroker] Remove lazy_static dependency
ClosedPublic
Actions

Authored by bartek on Aug 2 2023, 12:57 AM.

Details

Reviewers

• jon
varun

Commits

rCOMMf50c85cdd0fe: [tunnelbroker] Remove lazy_static dependency

Summary

Follow up ENG-2900.
This was a dead dependency - it's unused in tunnelbroker.

Test Plan

cd services/tunnelbroker && cargo build

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Aug 2 2023, 12:57 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 2 2023, 12:57 AM

Harbormaster completed remote builds in B21482: Diff 29472.Aug 2 2023, 1:19 AM

bartek requested review of this revision.Aug 2 2023, 1:19 AM

i think you can actually remove more than this :)

varun@varuns-MacBook-Pro tunnelbroker % cargo machete
Analyzing dependencies of crates in this directory...
cargo-machete found the following unused dependencies in /Users/varun/Code/comm/services/tunnelbroker:
tunnelbroker -- /Users/varun/Code/comm/services/tunnelbroker/Cargo.toml:
        a2
        aws-types
        base64
        env_logger
        fcm
        futures
        lazy_static
        log
        openssl
        prost
        prost-types
        tokio-stream
Done!

I think prost is actually required but everything else can probably be removed

• jon accepted this revision.Aug 3 2023, 11:16 AM

This revision is now accepted and ready to land.Aug 3 2023, 11:16 AM

Closed by commit rCOMMf50c85cdd0fe: [tunnelbroker] Remove lazy_static dependency (authored by bartek). · Explain WhyAug 4 2023, 8:05 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMf50c85cdd0fe: [tunnelbroker] Remove lazy_static dependency.