Page MenuHomePhabricator
Differential D8732

[keyserver] Run migration to update thread pinned_counts
ClosedPublic
Actions

Authored by rohan on Aug 4 2023, 8:34 AM.
Tags
None
Referenced Files
F3285135: D8732.id29548.diff
Sat, Nov 16, 12:26 PM
Unknown Object (File)
Mon, Nov 11, 4:56 PM
Unknown Object (File)
Sat, Oct 19, 5:06 AM
Unknown Object (File)
Sat, Oct 19, 5:06 AM
Unknown Object (File)
Sat, Oct 19, 5:06 AM
Unknown Object (File)
Sat, Oct 19, 5:06 AM
Unknown Object (File)
Sat, Oct 19, 5:06 AM
Unknown Object (File)
Sat, Oct 19, 5:04 AM
View All Files
Subscribers
ashoat

Details

Reviewers
atul
ginsu
tomek
ashoat
Commits
rCOMM1f65502417b0: [keyserver] Run migration to update thread pinned_counts
Summary

Based on the changes made in D8683, we should also run a
safeguard migration to update the threads.pinned_count values to match
the number of messages in the database that are pinned for each thread.

Depends on D8683

Test Plan
  1. Pinned some messages
  2. Set the threads.pinned_count = 0 to emulate a corrupt state that could occur because of this bug (invalid pinned_count value)
  3. Run the query
  4. Ensure that the pinned count values updated

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rohan created this revision.Aug 4 2023, 8:34 AM
Herald added a subscriber: ashoat. · View Herald TranscriptAug 4 2023, 8:34 AM
rohan edited the test plan for this revision. (Show Details)Aug 4 2023, 8:34 AM
Harbormaster completed remote builds in B21538: Diff 29546.Aug 4 2023, 8:51 AM
rohan requested review of this revision.Aug 4 2023, 8:51 AM
rohan added a child revision: D8733: [keyserver] Create toggle pin messages and updates in parallel.Aug 4 2023, 8:53 AM
ashoat accepted this revision.Aug 4 2023, 8:54 AM
ashoat added inline comments.
keyserver/src/database/migration-config.js
495–505 ↗(On Diff #29546)
  1. You can just return the promise directly
  2. Skip the semicolon unless using multipleStatements: true
This revision is now accepted and ready to land.Aug 4 2023, 8:54 AM
rohan updated this revision to Diff 29548.Aug 4 2023, 9:00 AM

Address feedback

rohan updated this revision to Diff 29550.Aug 4 2023, 9:02 AM

Fix formatting

Harbormaster completed remote builds in B21542: Diff 29550.Aug 4 2023, 9:19 AM
Harbormaster completed remote builds in B21540: Diff 29548.
Closed by commit rCOMM1f65502417b0: [keyserver] Run migration to update thread pinned_counts (authored by rohan). · Explain WhyAug 7 2023, 8:06 AM
This revision was automatically updated to reflect the committed changes.
rohan added a commit: rCOMM1f65502417b0: [keyserver] Run migration to update thread pinned_counts.

Revision Contents
Changeset List

PathSize
keyserver/
src/
database/
15 lines

Diff 29589

View Options

keyserver/src/database/migration-config.js

Loading...