[Buildkite] Add automatic retries to workflows missing it
ClosedPublic
Actions

Authored by atul on Aug 8 2023, 12:18 AM.

Details

Reviewers

ashoat
ginsu
rohan
tomek
kamil

Commits

rCOMM4a80b245a2c8: [Buildkite] Add automatic retries to workflows missing it

Summary

We previously added automatic retries to all of the Buildkite workflows. However, it looks like some of the newly introduced/edited workflows don't include the retries setting. Noticed macos workflow was missing retries when the following failed: https://buildkite.com/comm/macos-build-electron/builds/5628

Test Plan

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Aug 8 2023, 12:18 AM

atul published this revision for review.Aug 8 2023, 12:19 AM

Harbormaster completed remote builds in B21582: Diff 29607.Aug 8 2023, 12:37 AM

I guess we could have a test plan here: e.g. create a job that fails and check if it gets retried. But if we follow what's in other workflows, we shouldn't expect any differences.

This revision is now accepted and ready to land.Aug 8 2023, 1:22 AM

In D8756#258173, @tomek wrote:

I guess we could have a test plan here: e.g. create a job that fails and check if it gets retried. But if we follow what's in other workflows, we shouldn't expect any differences.

Yeah, I was thinking we could try to get each to fail intentionally... but figured we could trust that behavior would match other workflows

rebase and land

This revision was landed with ongoing or failed builds.Aug 8 2023, 1:55 AM

Closed by commit rCOMM4a80b245a2c8: [Buildkite] Add automatic retries to workflows missing it (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM4a80b245a2c8: [Buildkite] Add automatic retries to workflows missing it.

Harbormaster completed remote builds in B21586: Diff 29612.Aug 8 2023, 2:10 AM