Page MenuHomePhabricator
Differential D8768

[keyserver] Improve Flow types in update-creator
ClosedPublic
Actions

Authored by tomek on Aug 9 2023, 6:10 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 3:58 PM
Unknown Object (File)
Sun, Nov 10, 3:58 PM
Unknown Object (File)
Sun, Nov 10, 3:58 PM
Unknown Object (File)
Tue, Nov 5, 2:12 AM
Unknown Object (File)
Oct 6 2024, 3:00 PM
Unknown Object (File)
Oct 4 2024, 10:02 AM
Unknown Object (File)
Oct 4 2024, 10:02 AM
Unknown Object (File)
Oct 4 2024, 10:01 AM
View All 92 Files
Subscribers
ashoat

Details

Reviewers
kamil
bartek
inka
Commits
rCOMM43ac3121e913: [keyserver] Improve Flow types in update-creator
Summary

We had a type error and Flow was unable to detect that. This diff makes it so the type error would be reported and replaces false with null to satisfy type system. In fetchMessageInfos and parseMessageSelectionCriteria we're using threadCursors[threadID] in if conditions so it is safe to do that replacement.

https://linear.app/comm/issue/ENG-4592/improve-flow-types-in-update-creator

Test Plan

Console log messageInfoResult before and after change and check if the result remains correct.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.Aug 9 2023, 6:10 AM
Herald added a subscriber: ashoat. · View Herald TranscriptAug 9 2023, 6:10 AM
Harbormaster completed remote builds in B21671: Diff 29786.Aug 9 2023, 6:28 AM
tomek requested review of this revision.Aug 9 2023, 6:28 AM
tomek added a child revision: D8776: [keyserver] Group entry and message infos by threadID instead of iterating over them for each JOIN_THREAD update.Aug 10 2023, 5:03 AM
kamil accepted this revision.Aug 16 2023, 1:57 AM
kamil added inline comments.
keyserver/src/creators/update-creator.js
461 ↗(On Diff #29786)

Not sure if this will work, but if yes it seems safer

This revision is now accepted and ready to land.Aug 16 2023, 1:57 AM
tomek added inline comments.Aug 22 2023, 4:12 AM
keyserver/src/creators/update-creator.js
461 ↗(On Diff #29786)

It definitely would be safer but isn't possible because all the props of ThreadCursors are read-only.

Closed by commit rCOMM43ac3121e913: [keyserver] Improve Flow types in update-creator (authored by tomek). · Explain WhyAug 22 2023, 5:51 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM43ac3121e913: [keyserver] Improve Flow types in update-creator.

Revision Contents
Changeset List

PathSize
keyserver/
src/
creators/
8 lines

Diff 30217

View Options

keyserver/src/creators/update-creator.js

Loading...