Page MenuHomePhabricator

[keyserver] Group entry and message infos by threadID instead of iterating over them for each JOIN_THREAD update
ClosedPublic

Authored by tomek on Aug 10 2023, 5:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 14, 8:16 AM
Unknown Object (File)
Wed, Jun 12, 8:59 AM
Unknown Object (File)
Sat, Jun 8, 3:45 AM
Unknown Object (File)
Mon, Jun 3, 8:24 PM
Unknown Object (File)
Sun, Jun 2, 11:10 PM
Unknown Object (File)
Sat, May 18, 5:21 AM
Unknown Object (File)
Sat, May 18, 5:21 AM
Unknown Object (File)
Sat, May 18, 5:20 AM
Subscribers

Details

Summary

For each JOIN_THREAD update we were iterating over all the entry / message infos. Grouping them by threadID will improve the performance when we deliver more than one action of this type.

https://linear.app/comm/issue/ENG-4593/improve-updateinfosfromrawupdateinfos-performance-by-using-a-map

Depends on D8768

Test Plan

Reintroduce removed code and add console logs where we compare previous with new results. Then join a thread and check if the result is the same.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable