Page MenuHomePhabricator

Move `native`-specific `uploadSelectedMedia` from `updateImageThreadAvatar` to `nativeUpdateImageThreadAvatar`
ClosedPublic

Authored by atul on Aug 9 2023, 12:11 PM.
Tags
None
Referenced Files
F2202782: D8772.id29793.diff
Sat, Jul 6, 9:35 AM
Unknown Object (File)
Thu, Jul 4, 12:02 PM
Unknown Object (File)
Thu, Jul 4, 11:17 AM
Unknown Object (File)
Thu, Jul 4, 10:25 AM
Unknown Object (File)
Tue, Jul 2, 9:58 PM
Unknown Object (File)
Sat, Jun 15, 12:50 AM
Unknown Object (File)
Thu, Jun 13, 10:08 AM
Unknown Object (File)
Tue, Jun 11, 12:57 PM
Subscribers

Details

Summary

We remove the native-specific uploadSelectedMedia call from updateImageThreadAvatar and move it to the native-specific nativeUpdateThreadImageAvatar.

As of this diff, updateImageThreadAvatar now takes (imageAvatarUpdateRequest: ImageAvatarDBContent) rather than the native-specific (selection: NativeMediaSelection).

This diff also eliminates all usages of useUploadSelectedMedia, which means we can remvoe the prop in a subsequent diff at which point EditThreadAvatarProvider will be platform-agnostic.

Test Plan

Continue to be able to set image thread avatars on native as expected.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable