Page MenuHomePhabricator

Move `native`-specific `uploadSelectedMedia` from `updateImageThreadAvatar` to `nativeUpdateImageThreadAvatar`
ClosedPublic

Authored by atul on Aug 9 2023, 12:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 14, 3:52 PM
Unknown Object (File)
Thu, Sep 12, 8:45 PM
Unknown Object (File)
Sep 4 2024, 12:50 PM
Unknown Object (File)
Aug 30 2024, 1:29 AM
Unknown Object (File)
Aug 25 2024, 12:07 AM
Unknown Object (File)
Aug 25 2024, 12:07 AM
Unknown Object (File)
Aug 25 2024, 12:07 AM
Unknown Object (File)
Aug 25 2024, 12:07 AM
Subscribers

Details

Summary

We remove the native-specific uploadSelectedMedia call from updateImageThreadAvatar and move it to the native-specific nativeUpdateThreadImageAvatar.

As of this diff, updateImageThreadAvatar now takes (imageAvatarUpdateRequest: ImageAvatarDBContent) rather than the native-specific (selection: NativeMediaSelection).

This diff also eliminates all usages of useUploadSelectedMedia, which means we can remvoe the prop in a subsequent diff at which point EditThreadAvatarProvider will be platform-agnostic.

Test Plan

Continue to be able to set image thread avatars on native as expected.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage