Page MenuHomePhabricator

Move `native`-specific `uploadSelectedMedia` from `updateImageThreadAvatar` to `nativeUpdateImageThreadAvatar`
ClosedPublic

Authored by atul on Aug 9 2023, 12:11 PM.
Tags
None
Referenced Files
F2253584: D8772.id29798.diff
Fri, Jul 12, 1:29 PM
F2253583: D8772.id29796.diff
Fri, Jul 12, 1:29 PM
F2253582: D8772.id29793.diff
Fri, Jul 12, 1:29 PM
F2253573: D8772.id.diff
Fri, Jul 12, 1:29 PM
F2253552: D8772.diff
Fri, Jul 12, 1:27 PM
Unknown Object (File)
Sun, Jul 7, 3:52 AM
Unknown Object (File)
Sat, Jul 6, 9:35 AM
Unknown Object (File)
Thu, Jul 4, 12:02 PM
Subscribers

Details

Summary

We remove the native-specific uploadSelectedMedia call from updateImageThreadAvatar and move it to the native-specific nativeUpdateThreadImageAvatar.

As of this diff, updateImageThreadAvatar now takes (imageAvatarUpdateRequest: ImageAvatarDBContent) rather than the native-specific (selection: NativeMediaSelection).

This diff also eliminates all usages of useUploadSelectedMedia, which means we can remvoe the prop in a subsequent diff at which point EditThreadAvatarProvider will be platform-agnostic.

Test Plan

Continue to be able to set image thread avatars on native as expected.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage