Page MenuHomePhabricator
Differential D8788

[landing] address telegram comparison touch ups
ClosedPublic
Actions

Authored by ginsu on Aug 10 2023, 3:41 PM.
Tags
None
Referenced Files
F3529238: D8788.diff
Tue, Dec 24, 5:12 PM
Unknown Object (File)
Mon, Dec 9, 7:23 AM
Unknown Object (File)
Mon, Nov 25, 2:43 PM
Unknown Object (File)
Nov 23 2024, 4:32 AM
Unknown Object (File)
Nov 23 2024, 4:32 AM
Unknown Object (File)
Nov 21 2024, 8:19 AM
Unknown Object (File)
Nov 21 2024, 8:19 AM
Unknown Object (File)
Nov 21 2024, 8:18 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
kamil
ashoat
Commits
rCOMMe453ae676778: [landing] address telegram comparison touch ups
Summary

resolves the following telegram comparison copy touch up:

https://linear.app/comm/issue/ENG-4625/telegram-comparison

Depends on D8785

Test Plan

Please see screenshots:

Screenshot 2023-08-10 at 7.03.07 PM.png (2×3 px, 836 KB)

Screenshot 2023-08-10 at 7.03.20 PM.png (2×3 px, 1008 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Aug 10 2023, 3:41 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 10 2023, 3:41 PM
ginsu edited the summary of this revision. (Show Details)Aug 10 2023, 3:42 PM
ginsu added reviewers: atul, kamil.
ginsu added a parent revision: D8785: [landing] address keybase comparison touch ups.
Harbormaster completed remote builds in B21706: Diff 29831.Aug 10 2023, 3:59 PM
ginsu requested review of this revision.Aug 10 2023, 3:59 PM
ginsu edited the test plan for this revision. (Show Details)Aug 10 2023, 4:05 PM
ginsu attached a referenced file: F684744: Screenshot 2023-08-10 at 7.03.20 PM.png. (Show Details)
ginsu attached a referenced file: F684743: Screenshot 2023-08-10 at 7.03.07 PM.png. (Show Details)
ginsu added a child revision: D8792: [landing] address discord comparison touch ups.Aug 10 2023, 4:09 PM
ashoat accepted this revision.Aug 11 2023, 5:32 AM
This revision is now accepted and ready to land.Aug 11 2023, 5:32 AM
ginsu updated this revision to Diff 29889.Aug 15 2023, 7:26 AM

rebase before landing

This revision was landed with ongoing or failed builds.Aug 15 2023, 7:30 AM
Closed by commit rCOMMe453ae676778: [landing] address telegram comparison touch ups (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMe453ae676778: [landing] address telegram comparison touch ups.
Harbormaster completed remote builds in B21750: Diff 29889.Aug 15 2023, 7:47 AM

Revision Contents
Changeset List

PathSize
landing/
6 lines

Diff 29889

View Options

landing/competitor-data.js

Loading...