Page MenuHomePhabricator

[landing] address matrix comparison touch ups
ClosedPublic

Authored by ginsu on Aug 10 2023, 4:17 PM.
Tags
None
Referenced Files
F3529226: D8794.diff
Tue, Dec 24, 5:06 PM
Unknown Object (File)
Thu, Dec 5, 10:27 PM
Unknown Object (File)
Nov 23 2024, 11:47 PM
Unknown Object (File)
Nov 23 2024, 4:33 AM
Unknown Object (File)
Nov 21 2024, 8:19 AM
Unknown Object (File)
Nov 21 2024, 8:19 AM
Unknown Object (File)
Nov 21 2024, 8:19 AM
Unknown Object (File)
Nov 21 2024, 8:19 AM
Subscribers

Details

Summary

resolves the following matrix comparison copy touch up:

https://linear.app/comm/issue/ENG-4628/matrix-comparison

Depends on D8793

Test Plan

Please see screenshots:

Screenshot 2023-08-10 at 7.31.19 PM.png (2×3 px, 922 KB)

Screenshot 2023-08-10 at 7.29.30 PM.png (974×1 px, 87 KB)

Screenshot 2023-08-10 at 7.28.47 PM.png (2×3 px, 836 KB)

Diff Detail

Repository
rCOMM Comm
Branch
eng-4617 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, kamil.
ginsu requested review of this revision.Aug 10 2023, 4:35 PM
This revision is now accepted and ready to land.Aug 11 2023, 5:34 AM
ginsu edited the test plan for this revision. (Show Details)

address comments

This revision was landed with ongoing or failed builds.Aug 15 2023, 7:30 AM
This revision was automatically updated to reflect the committed changes.