Page MenuHomePhabricator

[keyserver] Convert urlInfo in website responders
ClosedPublic

Authored by michal on Aug 21 2023, 1:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 5:40 PM
Unknown Object (File)
Wed, Nov 20, 5:40 PM
Unknown Object (File)
Wed, Nov 20, 5:40 PM
Unknown Object (File)
Wed, Nov 20, 5:40 PM
Unknown Object (File)
Wed, Nov 20, 5:40 PM
Unknown Object (File)
Wed, Nov 20, 5:40 PM
Unknown Object (File)
Wed, Nov 20, 5:35 PM
Unknown Object (File)
Wed, Nov 13, 4:40 AM
Subscribers

Details

Summary

ENG-4670

We also need to convert the urlInfo in the website responder so it works on link containing the new id schema. We can also handle the older links by not converting (the older link already contain schema that's inside the keyserver db).

Depends on D8879 (moving stuff because of cyclic dependencies)

Test Plan

Open links:

Try opening links to non-existant threads:

Try navigating to settings and check if it worked correctly: http://localhost:3000/comm/settings/account/

Tried navigating to a pending (non-sidebar) threads with two users and was navigated correctly. Navigating to sidebar pending threads doesn't work but from analyzing the code and diffs it isn't supported by the keyserver anyway.

Also opened landing to check if there are no weird cyclic dependecies errors there

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

keyserver/src/responders/website-responders.js
279 ↗(On Diff #30147)

I'm confused why there is an await here. In master, infoFromURL does not return a Promise. I also don't see any changes to infoFromURL either in this diff, or the parent

Removed await. I think I just experimented with a few different solutions and this got left behind.

Please address my comment before landing

lib/utils/url-utils.js
23 ↗(On Diff #30148)

I think you need to rebase onto master and add qrCode

This revision is now accepted and ready to land.Aug 22 2023, 1:40 AM