Page MenuHomePhabricator
Differential D8923

[native] Refactor infinite image loader fix
ClosedPublic
Actions

Authored by • patryk on Aug 23 2023, 4:06 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 7, 5:42 AM
Unknown Object (File)
Fri, Mar 7, 5:25 AM
Unknown Object (File)
Mar 1 2025, 4:42 PM
Unknown Object (File)
Mar 1 2025, 4:42 PM
Unknown Object (File)
Mar 1 2025, 4:41 PM
Unknown Object (File)
Mar 1 2025, 4:28 PM
Unknown Object (File)
Feb 26 2025, 3:07 AM
Unknown Object (File)
Jan 25 2025, 2:52 AM
View All 80 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
Commits
rCOMM3e3f8b28d6fc: [native] Refactor infinite image loader fix
Summary

This diff fixes landed D8418 -> I've landed code which was written before review.

Test Plan

See if 28394 diff changes are applied.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
media/
5 lines
11 lines

Diff 30250

View Options

native/media/encrypted-image.react.js

// @flow // @flow
import { faBell, faCog } from '@fortawesome/free-solid-svg-icons';
import * as React from 'react'; import * as React from 'react';
import { type ThreadInfo } from 'lib/types/thread-types'; import { type ThreadInfo } from 'lib/types/thread-types';
import SWMansionIcon from '../SWMansionIcon.react'; import SWMansionIcon from '../SWMansionIcon.react';
import ThreadMenuItem from './thread-menu-item.react';
import css from './thread-menu.css'; import css from './thread-menu.css';
type ThreadMenuProps = { type ThreadMenuProps = {
+threadInfo: ThreadInfo, +threadInfo: ThreadInfo,
}; };
function ThreadMenu(props: ThreadMenuProps): React.Node { function ThreadMenu(props: ThreadMenuProps): React.Node {
const [isOpen, setIsOpen] = React.useState(false); const [isOpen, setIsOpen] = React.useState(false);
// eslint-disable-next-line no-unused-vars // eslint-disable-next-line no-unused-vars
const { threadInfo } = props; const { threadInfo } = props;
const menuItems = []; const menuItems = React.useMemo(() => {
const settingsItem = (
<ThreadMenuItem key="settings" text="Settings" icon={faCog} />
);
const notificationsItem = (
<ThreadMenuItem key="notifications" text="Notifications" icon={faBell} />
);
const items = [settingsItem, notificationsItem];
return items.filter(Boolean);
}, []);
const closeMenuCallback = React.useCallback(() => { const closeMenuCallback = React.useCallback(() => {
document.removeEventListener('click', closeMenuCallback); document.removeEventListener('click', closeMenuCallback);
if (isOpen) { if (isOpen) {
setIsOpen(false); setIsOpen(false);
} }
}, [isOpen]); }, [isOpen]);
Show All 34 Lines
View Options

native/media/loadable-image.react.js

// @flow // @flow
import { faBell, faCog } from '@fortawesome/free-solid-svg-icons';
import * as React from 'react'; import * as React from 'react';
import { type ThreadInfo } from 'lib/types/thread-types'; import { type ThreadInfo } from 'lib/types/thread-types';
import SWMansionIcon from '../SWMansionIcon.react'; import SWMansionIcon from '../SWMansionIcon.react';
import ThreadMenuItem from './thread-menu-item.react';
import css from './thread-menu.css'; import css from './thread-menu.css';
type ThreadMenuProps = { type ThreadMenuProps = {
+threadInfo: ThreadInfo, +threadInfo: ThreadInfo,
}; };
function ThreadMenu(props: ThreadMenuProps): React.Node { function ThreadMenu(props: ThreadMenuProps): React.Node {
const [isOpen, setIsOpen] = React.useState(false); const [isOpen, setIsOpen] = React.useState(false);
// eslint-disable-next-line no-unused-vars // eslint-disable-next-line no-unused-vars
const { threadInfo } = props; const { threadInfo } = props;
const menuItems = []; const menuItems = React.useMemo(() => {
const settingsItem = (
<ThreadMenuItem key="settings" text="Settings" icon={faCog} />
);
const notificationsItem = (
<ThreadMenuItem key="notifications" text="Notifications" icon={faBell} />
);
const items = [settingsItem, notificationsItem];
return items.filter(Boolean);
}, []);
const closeMenuCallback = React.useCallback(() => { const closeMenuCallback = React.useCallback(() => {
document.removeEventListener('click', closeMenuCallback); document.removeEventListener('click', closeMenuCallback);
if (isOpen) { if (isOpen) {
setIsOpen(false); setIsOpen(false);
} }
}, [isOpen]); }, [isOpen]);
Show All 34 Lines