Page MenuHomePhabricator
Differential D8923

[native] Refactor infinite image loader fix
ClosedPublic
Actions

Authored by • patryk on Aug 23 2023, 4:06 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 12, 3:10 PM
Unknown Object (File)
Wed, Apr 9, 12:53 AM
Unknown Object (File)
Wed, Apr 9, 12:13 AM
Unknown Object (File)
Tue, Apr 8, 10:55 PM
Unknown Object (File)
Tue, Apr 8, 10:25 PM
Unknown Object (File)
Sun, Apr 6, 12:03 PM
Unknown Object (File)
Sun, Apr 6, 1:15 AM
Unknown Object (File)
Sat, Apr 5, 9:18 PM
View All 90 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
Commits
rCOMM3e3f8b28d6fc: [native] Refactor infinite image loader fix
Summary

This diff fixes landed D8418 -> I've landed code which was written before review.

Test Plan

See if 28394 diff changes are applied.

Diff Detail

Repository
rCOMM Comm
Branch
patryk/fixfix
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
native/
media/
5 lines
11 lines

Diff 30249

View Options

native/media/encrypted-image.react.js

Show All 11 Lines
type RustAPI = { type RustAPI = {
+registerUser: ( +registerUser: (
userId: string, userId: string,
deviceId: string, deviceId: string,
username: string, username: string,
password: string, password: string,
userPublicKey: string, userPublicKey: string,
) => Promise<string>, ) => Promise<string>,
+deleteUser: (userId: string) => Promise<boolean>,
}; };
async function getRustAPI(): Promise<RustAPI> { async function getRustAPI(): Promise<RustAPI> {
let nativeBinding = null; let nativeBinding = null;
if (platform === 'darwin' && arch === 'x64') { if (platform === 'darwin' && arch === 'x64') {
// $FlowFixMe // $FlowFixMe
nativeBinding = require('./napi/rust-node-addon.darwin-x64.node'); nativeBinding = require('./napi/rust-node-addon.darwin-x64.node');
} else if (platform === 'darwin' && arch === 'arm64') { } else if (platform === 'darwin' && arch === 'arm64') {
// $FlowFixMe // $FlowFixMe
nativeBinding = require('./napi/rust-node-addon.darwin-arm64.node'); nativeBinding = require('./napi/rust-node-addon.darwin-arm64.node');
} else if (platform === 'linux' && arch === 'x64') { } else if (platform === 'linux' && arch === 'x64') {
// $FlowFixMe // $FlowFixMe
nativeBinding = require('./napi/rust-node-addon.linux-x64-gnu.node'); nativeBinding = require('./napi/rust-node-addon.linux-x64-gnu.node');
} else if (platform === 'linux' && arch === 'arm64') { } else if (platform === 'linux' && arch === 'arm64') {
// $FlowFixMe // $FlowFixMe
nativeBinding = require('./napi/rust-node-addon.linux-arm64-gnu.node'); nativeBinding = require('./napi/rust-node-addon.linux-arm64-gnu.node');
} else { } else {
throw new Error(`Unsupported OS: ${platform}, architecture: ${arch}`); throw new Error(`Unsupported OS: ${platform}, architecture: ${arch}`);
} }
if (!nativeBinding) { if (!nativeBinding) {
throw new Error('Failed to load native binding'); throw new Error('Failed to load native binding');
} }
const { registerUser } = nativeBinding; const { registerUser, deleteUser } = nativeBinding;
return { registerUser }; return { registerUser, deleteUser };
} }
export { getRustAPI }; export { getRustAPI };
View Options

native/media/loadable-image.react.js

Show All 11 Lines
type RustAPI = { type RustAPI = {
+registerUser: ( +registerUser: (
userId: string, userId: string,
deviceId: string, deviceId: string,
username: string, username: string,
password: string, password: string,
userPublicKey: string, userPublicKey: string,
) => Promise<string>, ) => Promise<string>,
+deleteUser: (userId: string) => Promise<boolean>,
}; };
async function getRustAPI(): Promise<RustAPI> { async function getRustAPI(): Promise<RustAPI> {
let nativeBinding = null; let nativeBinding = null;
if (platform === 'darwin' && arch === 'x64') { if (platform === 'darwin' && arch === 'x64') {
// $FlowFixMe // $FlowFixMe
nativeBinding = require('./napi/rust-node-addon.darwin-x64.node'); nativeBinding = require('./napi/rust-node-addon.darwin-x64.node');
} else if (platform === 'darwin' && arch === 'arm64') { } else if (platform === 'darwin' && arch === 'arm64') {
// $FlowFixMe // $FlowFixMe
nativeBinding = require('./napi/rust-node-addon.darwin-arm64.node'); nativeBinding = require('./napi/rust-node-addon.darwin-arm64.node');
} else if (platform === 'linux' && arch === 'x64') { } else if (platform === 'linux' && arch === 'x64') {
// $FlowFixMe // $FlowFixMe
nativeBinding = require('./napi/rust-node-addon.linux-x64-gnu.node'); nativeBinding = require('./napi/rust-node-addon.linux-x64-gnu.node');
} else if (platform === 'linux' && arch === 'arm64') { } else if (platform === 'linux' && arch === 'arm64') {
// $FlowFixMe // $FlowFixMe
nativeBinding = require('./napi/rust-node-addon.linux-arm64-gnu.node'); nativeBinding = require('./napi/rust-node-addon.linux-arm64-gnu.node');
} else { } else {
throw new Error(`Unsupported OS: ${platform}, architecture: ${arch}`); throw new Error(`Unsupported OS: ${platform}, architecture: ${arch}`);
} }
if (!nativeBinding) { if (!nativeBinding) {
throw new Error('Failed to load native binding'); throw new Error('Failed to load native binding');
} }
const { registerUser } = nativeBinding; const { registerUser, deleteUser } = nativeBinding;
return { registerUser }; return { registerUser, deleteUser };
} }
export { getRustAPI }; export { getRustAPI };