Page MenuHomePhabricator
Differential D8924

[keyserver][lib][native] Add connection to keyserverStore
ClosedPublic
Actions

Authored by inka on Aug 23 2023, 5:21 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 1, 3:25 PM
Unknown Object (File)
Sat, Mar 1, 3:25 PM
Unknown Object (File)
Sat, Mar 1, 3:23 PM
Unknown Object (File)
Sat, Mar 1, 3:00 PM
Unknown Object (File)
Jan 30 2025, 12:40 PM
Unknown Object (File)
Jan 30 2025, 12:01 PM
Unknown Object (File)
Jan 13 2025, 11:08 AM
Unknown Object (File)
Jan 12 2025, 3:46 AM
View All 74 Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
kamil
Commits
rCOMM22205172816b: [keyserver][lib][native] Add connection to keyserverStore
Summary

issue: https://linear.app/comm/issue/ENG-4460/refactor-connection-field
First step is to add connection field to keyserverStore

Test Plan

ran yarn flow-all

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka created this revision.Aug 23 2023, 5:21 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 23 2023, 5:21 AM
Harbormaster completed remote builds in B22035: Diff 30251.Aug 23 2023, 5:39 AM
inka requested review of this revision.Aug 23 2023, 5:39 AM
inka added a child revision: D8931: [lib][native][web] Use connection from keyserverStore.Aug 23 2023, 9:00 AM
michal accepted this revision.Aug 23 2023, 10:45 PM
This revision is now accepted and ready to land.Aug 23 2023, 10:45 PM
Closed by commit rCOMM22205172816b: [keyserver][lib][native] Add connection to keyserverStore (authored by inka). · Explain WhyAug 25 2023, 2:25 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMM22205172816b: [keyserver][lib][native] Add connection to keyserverStore.
inka mentioned this in D8950: Revert connction field refactor.Aug 25 2023, 7:47 AM
inka mentioned this in rCOMM633e6c16e4fa: Revert connction field refactor.Aug 25 2023, 8:40 AM
ashoat added inline comments.Sep 7 2023, 12:57 PM
keyserver/src/responders/website-responders.js
511

We should avoid await constructions like this. await keywords should appear at the start of a statement, or at the start of the right-hand side of an assignment. await is a very powerful keyword and we should always aim to make it very clear where it appears, instead of sneaking it into declarations like this.

const connectionPromise = (async () => {
  const actualizedCalendarQuery = await calendarQueryPromise;
  return {
    ...defaultConnectionInfo(viewer.platform ?? 'web', viewer.timeZone),
    actualizedCalendarQuery,
  };
})();

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
14 lines
lib/
reducers/
24 lines
types/
4 lines
native/
redux/
1 line

Diff 30302

View Options

keyserver/src/responders/website-responders.js

#pragma once #pragma once
#include "AwsTools.h" #include "AwsTools.h"
#include "Constants.h" #include "Constants.h"
#include "DatabaseEntitiesTools.h" #include "DatabaseEntitiesTools.h"
#include "Tools.h" #include "Tools.h"
#include <aws/core/Aws.h> #include <aws/core/Aws.h>
#include <aws/core/utils/Outcome.h> #include <aws/core/utils/Outcome.h>
#include <aws/dynamodb/model/AttributeDefinition.h> #include <aws/dynamodb/model/AttributeDefinition.h>
#include <aws/dynamodb/model/DeleteItemRequest.h> #include <aws/dynamodb/model/DeleteItemRequest.h>
#include <aws/dynamodb/model/DescribeTableRequest.h> #include <aws/dynamodb/model/DescribeTableRequest.h>
#include <aws/dynamodb/model/DescribeTableResult.h> #include <aws/dynamodb/model/DescribeTableResult.h>
#include <aws/dynamodb/model/GetItemRequest.h> #include <aws/dynamodb/model/GetItemRequest.h>
#include <aws/dynamodb/model/PutItemRequest.h> #include <aws/dynamodb/model/PutItemRequest.h>
#include <aws/dynamodb/model/QueryRequest.h>
#include <memory> #include <memory>
#include <string> #include <string>
namespace comm { namespace comm {
namespace network { namespace network {
namespace database { namespace database {
Show All 22 Linespublic:
void removeSessionSignItem(const std::string &deviceID); void removeSessionSignItem(const std::string &deviceID);
void putPublicKeyItem(const PublicKeyItem &item); void putPublicKeyItem(const PublicKeyItem &item);
std::shared_ptr<PublicKeyItem> findPublicKeyItem(const std::string &deviceID); std::shared_ptr<PublicKeyItem> findPublicKeyItem(const std::string &deviceID);
void removePublicKeyItem(const std::string &deviceID); void removePublicKeyItem(const std::string &deviceID);
void putMessageItem(const MessageItem &item); void putMessageItem(const MessageItem &item);
std::shared_ptr<MessageItem> findMessageItem(const std::string &messageID); std::shared_ptr<MessageItem> findMessageItem(const std::string &messageID);
std::vector<std::shared_ptr<MessageItem>>
findMessageItemsByReceiver(const std::string &toDeviceID);
void removeMessageItem(const std::string &messageID); void removeMessageItem(const std::string &messageID);
}; };
} // namespace database } // namespace database
} // namespace network } // namespace network
} // namespace comm } // namespace comm
View Options

lib/reducers/keyserver-reducer.js

#pragma once #pragma once
#include "AwsTools.h" #include "AwsTools.h"
#include "Constants.h" #include "Constants.h"
#include "DatabaseEntitiesTools.h" #include "DatabaseEntitiesTools.h"
#include "Tools.h" #include "Tools.h"
#include <aws/core/Aws.h> #include <aws/core/Aws.h>
#include <aws/core/utils/Outcome.h> #include <aws/core/utils/Outcome.h>
#include <aws/dynamodb/model/AttributeDefinition.h> #include <aws/dynamodb/model/AttributeDefinition.h>
#include <aws/dynamodb/model/DeleteItemRequest.h> #include <aws/dynamodb/model/DeleteItemRequest.h>
#include <aws/dynamodb/model/DescribeTableRequest.h> #include <aws/dynamodb/model/DescribeTableRequest.h>
#include <aws/dynamodb/model/DescribeTableResult.h> #include <aws/dynamodb/model/DescribeTableResult.h>
#include <aws/dynamodb/model/GetItemRequest.h> #include <aws/dynamodb/model/GetItemRequest.h>
#include <aws/dynamodb/model/PutItemRequest.h> #include <aws/dynamodb/model/PutItemRequest.h>
#include <aws/dynamodb/model/QueryRequest.h>
#include <memory> #include <memory>
#include <string> #include <string>
namespace comm { namespace comm {
namespace network { namespace network {
namespace database { namespace database {
Show All 22 Linespublic:
void removeSessionSignItem(const std::string &deviceID); void removeSessionSignItem(const std::string &deviceID);
void putPublicKeyItem(const PublicKeyItem &item); void putPublicKeyItem(const PublicKeyItem &item);
std::shared_ptr<PublicKeyItem> findPublicKeyItem(const std::string &deviceID); std::shared_ptr<PublicKeyItem> findPublicKeyItem(const std::string &deviceID);
void removePublicKeyItem(const std::string &deviceID); void removePublicKeyItem(const std::string &deviceID);
void putMessageItem(const MessageItem &item); void putMessageItem(const MessageItem &item);
std::shared_ptr<MessageItem> findMessageItem(const std::string &messageID); std::shared_ptr<MessageItem> findMessageItem(const std::string &messageID);
std::vector<std::shared_ptr<MessageItem>>
findMessageItemsByReceiver(const std::string &toDeviceID);
void removeMessageItem(const std::string &messageID); void removeMessageItem(const std::string &messageID);
}; };
} // namespace database } // namespace database
} // namespace network } // namespace network
} // namespace comm } // namespace comm
View Options

lib/types/keyserver-types.js

#pragma once #pragma once
#include "AwsTools.h" #include "AwsTools.h"
#include "Constants.h" #include "Constants.h"
#include "DatabaseEntitiesTools.h" #include "DatabaseEntitiesTools.h"
#include "Tools.h" #include "Tools.h"
#include <aws/core/Aws.h> #include <aws/core/Aws.h>
#include <aws/core/utils/Outcome.h> #include <aws/core/utils/Outcome.h>
#include <aws/dynamodb/model/AttributeDefinition.h> #include <aws/dynamodb/model/AttributeDefinition.h>
#include <aws/dynamodb/model/DeleteItemRequest.h> #include <aws/dynamodb/model/DeleteItemRequest.h>
#include <aws/dynamodb/model/DescribeTableRequest.h> #include <aws/dynamodb/model/DescribeTableRequest.h>
#include <aws/dynamodb/model/DescribeTableResult.h> #include <aws/dynamodb/model/DescribeTableResult.h>
#include <aws/dynamodb/model/GetItemRequest.h> #include <aws/dynamodb/model/GetItemRequest.h>
#include <aws/dynamodb/model/PutItemRequest.h> #include <aws/dynamodb/model/PutItemRequest.h>
#include <aws/dynamodb/model/QueryRequest.h>
#include <memory> #include <memory>
#include <string> #include <string>
namespace comm { namespace comm {
namespace network { namespace network {
namespace database { namespace database {
Show All 22 Linespublic:
void removeSessionSignItem(const std::string &deviceID); void removeSessionSignItem(const std::string &deviceID);
void putPublicKeyItem(const PublicKeyItem &item); void putPublicKeyItem(const PublicKeyItem &item);
std::shared_ptr<PublicKeyItem> findPublicKeyItem(const std::string &deviceID); std::shared_ptr<PublicKeyItem> findPublicKeyItem(const std::string &deviceID);
void removePublicKeyItem(const std::string &deviceID); void removePublicKeyItem(const std::string &deviceID);
void putMessageItem(const MessageItem &item); void putMessageItem(const MessageItem &item);
std::shared_ptr<MessageItem> findMessageItem(const std::string &messageID); std::shared_ptr<MessageItem> findMessageItem(const std::string &messageID);
std::vector<std::shared_ptr<MessageItem>>
findMessageItemsByReceiver(const std::string &toDeviceID);
void removeMessageItem(const std::string &messageID); void removeMessageItem(const std::string &messageID);
}; };
} // namespace database } // namespace database
} // namespace network } // namespace network
} // namespace comm } // namespace comm
View Options

native/redux/redux-setup.js

#pragma once #pragma once
#include "AwsTools.h" #include "AwsTools.h"
#include "Constants.h" #include "Constants.h"
#include "DatabaseEntitiesTools.h" #include "DatabaseEntitiesTools.h"
#include "Tools.h" #include "Tools.h"
#include <aws/core/Aws.h> #include <aws/core/Aws.h>
#include <aws/core/utils/Outcome.h> #include <aws/core/utils/Outcome.h>
#include <aws/dynamodb/model/AttributeDefinition.h> #include <aws/dynamodb/model/AttributeDefinition.h>
#include <aws/dynamodb/model/DeleteItemRequest.h> #include <aws/dynamodb/model/DeleteItemRequest.h>
#include <aws/dynamodb/model/DescribeTableRequest.h> #include <aws/dynamodb/model/DescribeTableRequest.h>
#include <aws/dynamodb/model/DescribeTableResult.h> #include <aws/dynamodb/model/DescribeTableResult.h>
#include <aws/dynamodb/model/GetItemRequest.h> #include <aws/dynamodb/model/GetItemRequest.h>
#include <aws/dynamodb/model/PutItemRequest.h> #include <aws/dynamodb/model/PutItemRequest.h>
#include <aws/dynamodb/model/QueryRequest.h>
#include <memory> #include <memory>
#include <string> #include <string>
namespace comm { namespace comm {
namespace network { namespace network {
namespace database { namespace database {
Show All 22 Linespublic:
void removeSessionSignItem(const std::string &deviceID); void removeSessionSignItem(const std::string &deviceID);
void putPublicKeyItem(const PublicKeyItem &item); void putPublicKeyItem(const PublicKeyItem &item);
std::shared_ptr<PublicKeyItem> findPublicKeyItem(const std::string &deviceID); std::shared_ptr<PublicKeyItem> findPublicKeyItem(const std::string &deviceID);
void removePublicKeyItem(const std::string &deviceID); void removePublicKeyItem(const std::string &deviceID);
void putMessageItem(const MessageItem &item); void putMessageItem(const MessageItem &item);
std::shared_ptr<MessageItem> findMessageItem(const std::string &messageID); std::shared_ptr<MessageItem> findMessageItem(const std::string &messageID);
std::vector<std::shared_ptr<MessageItem>>
findMessageItemsByReceiver(const std::string &toDeviceID);
void removeMessageItem(const std::string &messageID); void removeMessageItem(const std::string &messageID);
}; };
} // namespace database } // namespace database
} // namespace network } // namespace network
} // namespace comm } // namespace comm