Page MenuHomePhabricator

[keyserver][lib][native] Add connection to keyserverStore
ClosedPublic

Authored by inka on Aug 23 2023, 5:21 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 1, 10:50 AM
Unknown Object (File)
Oct 15 2024, 6:00 AM
Unknown Object (File)
Oct 15 2024, 6:00 AM
Unknown Object (File)
Oct 15 2024, 5:59 AM
Unknown Object (File)
Oct 15 2024, 5:38 AM
Unknown Object (File)
Oct 14 2024, 3:24 AM
Unknown Object (File)
Sep 14 2024, 9:50 PM
Unknown Object (File)
Sep 13 2024, 5:39 AM
Subscribers

Details

Summary

issue: https://linear.app/comm/issue/ENG-4460/refactor-connection-field
First step is to add connection field to keyserverStore

Test Plan

ran yarn flow-all

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka requested review of this revision.Aug 23 2023, 5:39 AM
This revision is now accepted and ready to land.Aug 23 2023, 10:45 PM
keyserver/src/responders/website-responders.js
511

We should avoid await constructions like this. await keywords should appear at the start of a statement, or at the start of the right-hand side of an assignment. await is a very powerful keyword and we should always aim to make it very clear where it appears, instead of sneaking it into declarations like this.

const connectionPromise = (async () => {
  const actualizedCalendarQuery = await calendarQueryPromise;
  return {
    ...defaultConnectionInfo(viewer.platform ?? 'web', viewer.timeZone),
    actualizedCalendarQuery,
  };
})();