Page MenuHomePhabricator

[lib][native][web] Use connection from keyserverStore
ClosedPublic

Authored by inka on Aug 23 2023, 8:44 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jun 25, 9:34 AM
Unknown Object (File)
Tue, Jun 25, 9:34 AM
Unknown Object (File)
Tue, Jun 25, 9:34 AM
Unknown Object (File)
Tue, Jun 25, 9:30 AM
Unknown Object (File)
Tue, Jun 25, 3:26 AM
Unknown Object (File)
Mon, Jun 24, 11:39 PM
Unknown Object (File)
Mon, Jun 24, 1:07 AM
Unknown Object (File)
Sun, Jun 23, 11:21 PM
Subscribers

Details

Summary

issue: https://linear.app/comm/issue/ENG-4460/refactor-connection-field
The second step is to start using connection from keyserverStore.

Some explanations:
master-reducer: once actions have a defined way of extracting keyserver id from their arguments we will use the correct id instead of ashoatKeyserverID
about invariants:

Test Plan

ran yarn flow-all. Checked that the app works, and the "Disconnected" bar is not present when app is connected, and is present when keyserver is down.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka requested review of this revision.Aug 23 2023, 9:02 AM

Thank you for all links for the invariants!

This revision is now accepted and ready to land.Aug 23 2023, 10:45 PM