Page MenuHomePhabricator

[blob-service] Remove gRPC service, change default port
ClosedPublic

Authored by bartek on Aug 26 2023, 12:16 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 27, 5:01 PM
Unknown Object (File)
Sat, Oct 12, 11:51 AM
Unknown Object (File)
Oct 2 2024, 8:14 PM
Unknown Object (File)
Sep 27 2024, 11:57 PM
Unknown Object (File)
Sep 27 2024, 11:57 PM
Unknown Object (File)
Sep 27 2024, 11:57 PM
Unknown Object (File)
Sep 27 2024, 11:57 PM
Unknown Object (File)
Sep 27 2024, 11:49 PM
Subscribers

Details

Summary

In D8796 we removed last blob gRPC client. This diff removes gRPC server as well.

First part of ENG-4297.

  • Deletes all gRPC related code from Blob service.
  • Changes default HTTP port to 50053.
Test Plan

HTTP service still works.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek held this revision as a draft.

Remove proto from dockerfile

bartek published this revision for review.Aug 26 2023, 12:43 AM
bartek added inline comments.
services/blob/src/config.rs
31 ↗(On Diff #30350)

In response to @jon's comment in https://phab.comm.dev/D8865?id=30062#inline-56777 I decided to return this from the function so we can take advantage of both:

  • convenience of using static CONFIG where it's cumbersome to pass it through args
  • correctness from aforementioned comment - we return the config from this function so it can be just passed further wherever needed
This revision is now accepted and ready to land.Aug 28 2023, 12:44 AM
services/blob/src/config.rs
14 ↗(On Diff #30350)

Would it make sense to remove the constant and default to the ports in .env like tests? One less thing to keep in sync