Page MenuHomePhabricator
Differential D9023

[keyserver][lib][native][web] Remove connection field from redux
ClosedPublic
Actions

Authored by inka on Aug 30 2023, 5:42 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 3, 11:58 AM
Unknown Object (File)
Thu, Apr 3, 1:56 AM
Unknown Object (File)
Thu, Apr 3, 12:37 AM
Unknown Object (File)
Wed, Apr 2, 9:09 PM
Unknown Object (File)
Wed, Apr 2, 12:02 AM
Unknown Object (File)
Sun, Mar 30, 9:12 PM
Unknown Object (File)
Mar 1 2025, 3:24 PM
Unknown Object (File)
Mar 1 2025, 3:24 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
kamil
Commits
rCOMM57926caeb969: [keyserver][lib][native][web] Remove connection field from redux
Summary

issue: https://linear.app/comm/issue/ENG-4460/refactor-connection-field
This diff is the same as D8932, but this time we don't need a migration because connection is not being persisted. This diff does make it temporarily be presisted, becuse all of
keyserverStore is being persisted. I will fix this in the next diff

Test Plan

ran yarn flow-all.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
10 lines
lib/
reducers/
4 lines
types/
2 lines
native/
redux/
1 line
2 lines
web/
redux/
2 lines

Diff 30641

View Options

keyserver/src/responders/website-responders.js

// @flow // @flow
import type { ResponseFailure } from '@parse/node-apn'; import type { ResponseFailure } from '@parse/node-apn';
import type { FirebaseApp, FirebaseError } from 'firebase-admin'; import type { FirebaseApp, FirebaseError } from 'firebase-admin';
import invariant from 'invariant'; import invariant from 'invariant';
import nodeFetch from 'node-fetch'; import nodeFetch from 'node-fetch';
import type { Response } from 'node-fetch'; import type { Response } from 'node-fetch';
import uuid from 'uuid';
import webpush from 'web-push'; import webpush from 'web-push';
import type { PlatformDetails } from 'lib/types/device-types.js'; import type { PlatformDetails } from 'lib/types/device-types.js';
import { threadSubscriptions } from 'lib/types/subscription-types.js'; import { threadSubscriptions } from 'lib/types/subscription-types.js';
import { threadPermissions } from 'lib/types/thread-permission-types.js'; import { threadPermissions } from 'lib/types/thread-permission-types.js';
import { encryptBlobPayload } from './crypto.js';
import { import {
getAPNPushProfileForCodeVersion, getAPNPushProfileForCodeVersion,
getFCMPushProfileForCodeVersion, getFCMPushProfileForCodeVersion,
getAPNProvider, getAPNProvider,
getFCMProvider, getFCMProvider,
ensureWebPushInitialized, ensureWebPushInitialized,
getWNSToken, getWNSToken,
} from './providers.js'; } from './providers.js';
▲ Show 20 Lines • Show All 362 Lines • ▼ Show 20 Lines
async function blobServiceUpload(payload: string): Promise< async function blobServiceUpload(payload: string): Promise<
| { | {
+blobHash: string, +blobHash: string,
+encryptionKey: string, +encryptionKey: string,
} }
| { +blobUploadError: string }, | { +blobUploadError: string },
> { > {
return upload(payload); const blobHolder = uuid.v4();
try {
const { encryptionKey, encryptedPayload, encryptedPayloadHash } =
await encryptBlobPayload(payload);
await upload(encryptedPayload, encryptedPayloadHash, blobHolder);
return {
blobHash: encryptedPayloadHash,
encryptionKey,
};
} catch (e) {
return {
blobUploadError: e.message,
};
}
} }
export { export {
apnPush, apnPush,
blobServiceUpload, blobServiceUpload,
fcmPush, fcmPush,
webPush, webPush,
wnsPush, wnsPush,
getUnreadCounts, getUnreadCounts,
apnMaxNotificationPayloadByteSize, apnMaxNotificationPayloadByteSize,
fcmMaxNotificationPayloadByteSize, fcmMaxNotificationPayloadByteSize,
wnsMaxNotificationPayloadByteSize, wnsMaxNotificationPayloadByteSize,
}; };
View Options

lib/reducers/master-reducer.js

// @flow // @flow
import type { ResponseFailure } from '@parse/node-apn'; import type { ResponseFailure } from '@parse/node-apn';
import type { FirebaseApp, FirebaseError } from 'firebase-admin'; import type { FirebaseApp, FirebaseError } from 'firebase-admin';
import invariant from 'invariant'; import invariant from 'invariant';
import nodeFetch from 'node-fetch'; import nodeFetch from 'node-fetch';
import type { Response } from 'node-fetch'; import type { Response } from 'node-fetch';
import uuid from 'uuid';
import webpush from 'web-push'; import webpush from 'web-push';
import type { PlatformDetails } from 'lib/types/device-types.js'; import type { PlatformDetails } from 'lib/types/device-types.js';
import { threadSubscriptions } from 'lib/types/subscription-types.js'; import { threadSubscriptions } from 'lib/types/subscription-types.js';
import { threadPermissions } from 'lib/types/thread-permission-types.js'; import { threadPermissions } from 'lib/types/thread-permission-types.js';
import { encryptBlobPayload } from './crypto.js';
import { import {
getAPNPushProfileForCodeVersion, getAPNPushProfileForCodeVersion,
getFCMPushProfileForCodeVersion, getFCMPushProfileForCodeVersion,
getAPNProvider, getAPNProvider,
getFCMProvider, getFCMProvider,
ensureWebPushInitialized, ensureWebPushInitialized,
getWNSToken, getWNSToken,
} from './providers.js'; } from './providers.js';
▲ Show 20 Lines • Show All 362 Lines • ▼ Show 20 Lines
async function blobServiceUpload(payload: string): Promise< async function blobServiceUpload(payload: string): Promise<
| { | {
+blobHash: string, +blobHash: string,
+encryptionKey: string, +encryptionKey: string,
} }
| { +blobUploadError: string }, | { +blobUploadError: string },
> { > {
return upload(payload); const blobHolder = uuid.v4();
try {
const { encryptionKey, encryptedPayload, encryptedPayloadHash } =
await encryptBlobPayload(payload);
await upload(encryptedPayload, encryptedPayloadHash, blobHolder);
return {
blobHash: encryptedPayloadHash,
encryptionKey,
};
} catch (e) {
return {
blobUploadError: e.message,
};
}
} }
export { export {
apnPush, apnPush,
blobServiceUpload, blobServiceUpload,
fcmPush, fcmPush,
webPush, webPush,
wnsPush, wnsPush,
getUnreadCounts, getUnreadCounts,
apnMaxNotificationPayloadByteSize, apnMaxNotificationPayloadByteSize,
fcmMaxNotificationPayloadByteSize, fcmMaxNotificationPayloadByteSize,
wnsMaxNotificationPayloadByteSize, wnsMaxNotificationPayloadByteSize,
}; };
View Options

lib/types/redux-types.js

// @flow // @flow
import type { ResponseFailure } from '@parse/node-apn'; import type { ResponseFailure } from '@parse/node-apn';
import type { FirebaseApp, FirebaseError } from 'firebase-admin'; import type { FirebaseApp, FirebaseError } from 'firebase-admin';
import invariant from 'invariant'; import invariant from 'invariant';
import nodeFetch from 'node-fetch'; import nodeFetch from 'node-fetch';
import type { Response } from 'node-fetch'; import type { Response } from 'node-fetch';
import uuid from 'uuid';
import webpush from 'web-push'; import webpush from 'web-push';
import type { PlatformDetails } from 'lib/types/device-types.js'; import type { PlatformDetails } from 'lib/types/device-types.js';
import { threadSubscriptions } from 'lib/types/subscription-types.js'; import { threadSubscriptions } from 'lib/types/subscription-types.js';
import { threadPermissions } from 'lib/types/thread-permission-types.js'; import { threadPermissions } from 'lib/types/thread-permission-types.js';
import { encryptBlobPayload } from './crypto.js';
import { import {
getAPNPushProfileForCodeVersion, getAPNPushProfileForCodeVersion,
getFCMPushProfileForCodeVersion, getFCMPushProfileForCodeVersion,
getAPNProvider, getAPNProvider,
getFCMProvider, getFCMProvider,
ensureWebPushInitialized, ensureWebPushInitialized,
getWNSToken, getWNSToken,
} from './providers.js'; } from './providers.js';
▲ Show 20 Lines • Show All 362 Lines • ▼ Show 20 Lines
async function blobServiceUpload(payload: string): Promise< async function blobServiceUpload(payload: string): Promise<
| { | {
+blobHash: string, +blobHash: string,
+encryptionKey: string, +encryptionKey: string,
} }
| { +blobUploadError: string }, | { +blobUploadError: string },
> { > {
return upload(payload); const blobHolder = uuid.v4();
try {
const { encryptionKey, encryptedPayload, encryptedPayloadHash } =
await encryptBlobPayload(payload);
await upload(encryptedPayload, encryptedPayloadHash, blobHolder);
return {
blobHash: encryptedPayloadHash,
encryptionKey,
};
} catch (e) {
return {
blobUploadError: e.message,
};
}
} }
export { export {
apnPush, apnPush,
blobServiceUpload, blobServiceUpload,
fcmPush, fcmPush,
webPush, webPush,
wnsPush, wnsPush,
getUnreadCounts, getUnreadCounts,
apnMaxNotificationPayloadByteSize, apnMaxNotificationPayloadByteSize,
fcmMaxNotificationPayloadByteSize, fcmMaxNotificationPayloadByteSize,
wnsMaxNotificationPayloadByteSize, wnsMaxNotificationPayloadByteSize,
}; };
View Options

native/redux/redux-setup.js

// @flow // @flow
import type { ResponseFailure } from '@parse/node-apn'; import type { ResponseFailure } from '@parse/node-apn';
import type { FirebaseApp, FirebaseError } from 'firebase-admin'; import type { FirebaseApp, FirebaseError } from 'firebase-admin';
import invariant from 'invariant'; import invariant from 'invariant';
import nodeFetch from 'node-fetch'; import nodeFetch from 'node-fetch';
import type { Response } from 'node-fetch'; import type { Response } from 'node-fetch';
import uuid from 'uuid';
import webpush from 'web-push'; import webpush from 'web-push';
import type { PlatformDetails } from 'lib/types/device-types.js'; import type { PlatformDetails } from 'lib/types/device-types.js';
import { threadSubscriptions } from 'lib/types/subscription-types.js'; import { threadSubscriptions } from 'lib/types/subscription-types.js';
import { threadPermissions } from 'lib/types/thread-permission-types.js'; import { threadPermissions } from 'lib/types/thread-permission-types.js';
import { encryptBlobPayload } from './crypto.js';
import { import {
getAPNPushProfileForCodeVersion, getAPNPushProfileForCodeVersion,
getFCMPushProfileForCodeVersion, getFCMPushProfileForCodeVersion,
getAPNProvider, getAPNProvider,
getFCMProvider, getFCMProvider,
ensureWebPushInitialized, ensureWebPushInitialized,
getWNSToken, getWNSToken,
} from './providers.js'; } from './providers.js';
▲ Show 20 Lines • Show All 362 Lines • ▼ Show 20 Lines
async function blobServiceUpload(payload: string): Promise< async function blobServiceUpload(payload: string): Promise<
| { | {
+blobHash: string, +blobHash: string,
+encryptionKey: string, +encryptionKey: string,
} }
| { +blobUploadError: string }, | { +blobUploadError: string },
> { > {
return upload(payload); const blobHolder = uuid.v4();
try {
const { encryptionKey, encryptedPayload, encryptedPayloadHash } =
await encryptBlobPayload(payload);
await upload(encryptedPayload, encryptedPayloadHash, blobHolder);
return {
blobHash: encryptedPayloadHash,
encryptionKey,
};
} catch (e) {
return {
blobUploadError: e.message,
};
}
} }
export { export {
apnPush, apnPush,
blobServiceUpload, blobServiceUpload,
fcmPush, fcmPush,
webPush, webPush,
wnsPush, wnsPush,
getUnreadCounts, getUnreadCounts,
apnMaxNotificationPayloadByteSize, apnMaxNotificationPayloadByteSize,
fcmMaxNotificationPayloadByteSize, fcmMaxNotificationPayloadByteSize,
wnsMaxNotificationPayloadByteSize, wnsMaxNotificationPayloadByteSize,
}; };
View Options

native/redux/state-types.js

Loading...
View Options

web/redux/redux-setup.js

Loading...