Paths

Table of Contentst

Differential D9023

[keyserver][lib][native][web] Remove connection field from redux
ClosedPublic
Actions

Authored by inka on Aug 30 2023, 5:42 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Nov 12, 6:56 AM

	Unknown Object (File)
	Mon, Nov 11, 8:20 AM

	Unknown Object (File)
	Fri, Nov 8, 12:24 AM

	Unknown Object (File)
	Thu, Oct 24, 3:28 AM

	Unknown Object (File)
	Oct 15 2024, 6:01 AM

	Unknown Object (File)
	Oct 15 2024, 6:01 AM

	Unknown Object (File)
	Oct 15 2024, 6:01 AM

	Unknown Object (File)
	Oct 15 2024, 5:59 AM

View All 71 Files

Subscribers

Details

Reviewers

michal
kamil

Commits

rCOMM57926caeb969: [keyserver][lib][native][web] Remove connection field from redux

Summary

issue: https://linear.app/comm/issue/ENG-4460/refactor-connection-field
This diff is the same as D8932, but this time we don't need a migration because connection is not being persisted. This diff does make it temporarily be presisted, becuse all of
keyserverStore is being persisted. I will fix this in the next diff

Test Plan

ran yarn flow-all.

Diff Detail

Repository

Branch

inka/connection

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Aug 30 2023, 5:42 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 30 2023, 5:42 AM

inka added a parent revision: D9022: [lib][native][web] Use connection from keyserverStore.Aug 30 2023, 5:42 AM

Harbormaster completed remote builds in B22249: Diff 30546.Aug 30 2023, 6:01 AM

inka requested review of this revision.Aug 30 2023, 6:01 AM

michal accepted this revision.Aug 30 2023, 6:14 AM

This revision is now accepted and ready to land.Aug 30 2023, 6:14 AM

inka added a child revision: D9024: [native] Stop persisting connection in keyserverStore.Aug 30 2023, 6:43 AM

Rebase

Harbormaster completed remote builds in B22304: Diff 30629.Aug 31 2023, 2:53 AM

Closed by commit rCOMM57926caeb969: [keyserver][lib][native][web] Remove connection field from redux (authored by inka). · Explain WhyAug 31 2023, 5:19 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMM57926caeb969: [keyserver][lib][native][web] Remove connection field from redux.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

responders/

website-responders.js

10 lines

lib/

reducers/

master-reducer.js

4 lines

types/

2 lines

native/

redux/

1 line

2 lines

web/

redux/

2 lines

Diff 30546

keyserver/src/responders/website-responders.js

Loading...

lib/reducers/master-reducer.js

Loading...

lib/types/redux-types.js

Loading...

native/redux/redux-setup.js

Loading...

native/redux/state-types.js

Loading...

web/redux/redux-setup.js

Loading...