[dockerignore] Add missing entries
ClosedPublic
Actions

Authored by bartek on Aug 30 2023, 1:54 PM.

Details

Reviewers

• jon
varun
michal

Commits

rCOMMf19ace81c9e4: [dockerignore] Add missing entries

Summary

Noticed that many things weren't dockerignored, especially the target directories in services (Rust build artifacts dir)

Test Plan

CI docker builds, also seen improvement in docker build context size.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Aug 30 2023, 1:54 PM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 30 2023, 1:54 PM

bartek added a child revision: D9037: [reports-service] Add Dockerfile.Aug 30 2023, 1:58 PM

Harbormaster completed remote builds in B22283: Diff 30608.Aug 30 2023, 2:18 PM

bartek published this revision for review.Aug 30 2023, 2:27 PM

Can we also add native/native_rust_library/target?

Also I wasn't aware of this when I was implementing the desktop app so we can also add:

desktop/node_modules
desktop/out
desktop/assets
desktop/dist
desktop/*.provisionprofile to avoid accidentally leaking them (note: I don't think anyone other than me was building signed macOS apps, and at that time the only docker image I built was electron-update-server which I checked and it doesn't copy anything in desktop/)

This revision is now accepted and ready to land.Aug 31 2023, 2:25 AM

In D9036#266402, @michal wrote:

Can we also add native/native_rust_library/target?

The whole native, with some exceptions, is already added.

Also I wasn't aware of this when I was implementing the desktop app so we can also add:

desktop/node_modules

desktop/out

desktop/assets

desktop/dist

desktop/*.provisionprofile to avoid accidentally leaking them (note: I don't think anyone other than me was building signed macOS apps, and at that time the only docker image I built was electron-update-server which I checked and it doesn't copy anything in desktop/)

Sure

Add requested entries

The whole native, with some exceptions, is already added.

Oh right. In that case is the native/cpp/**/build not needed?

Harbormaster completed remote builds in B22311: Diff 30651.Aug 31 2023, 6:30 AM

In D9036#266538, @michal wrote:

The whole native, with some exceptions, is already added.

Oh right. In that case is the native/cpp/**/build not needed?

Apparently not, will remove it before landing

Closed by commit rCOMMf19ace81c9e4: [dockerignore] Add missing entries (authored by bartek). · Explain WhySep 3 2023, 11:41 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMf19ace81c9e4: [dockerignore] Add missing entries.