Created a function to send reports to the reports service.
We support both single or multiple reports in one request.
Depends on D9041
Details
Details
- Reviewers
kamil michal tomek inka - Commits
- rCOMM56e629f020f4: [lib] Add function to send reports
Tested in the next diff.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| lib/utils/reports-service.js | ||
|---|---|---|
| 15 ↗ | (On Diff #30616) | Technically, the service accepts both object or array, but this way is easier to do the below preprocessing |
| lib/utils/reports-service.js | ||
|---|---|---|
| 37–44 ↗ | (On Diff #30616) | It is quite surprising to see an empty catch and unconditional throw. I guess it might be less surprising to use finally |
| lib/utils/reports-service.js | ||
|---|---|---|
| 37–44 ↗ | (On Diff #30616) | yes it's better. Still forgetting that JS supports the finally block |