Paths

Table of Contentst

Differential D9079

[lib][web][native] Start using lastCommunicatedPlatformDetailsSelector from keyserverStore
ClosedPublic
Actions

Authored by inka on Sep 5 2023, 3:04 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Nov 6, 7:08 AM

	Unknown Object (File)
	Thu, Oct 17, 12:08 PM

	Unknown Object (File)
	Thu, Oct 17, 12:07 PM

	Unknown Object (File)
	Thu, Oct 17, 12:07 PM

	Unknown Object (File)
	Thu, Oct 17, 12:05 PM

	Unknown Object (File)
	Sat, Oct 12, 5:23 PM

	Unknown Object (File)
	Sat, Oct 12, 3:30 AM

	Unknown Object (File)
	Oct 5 2024, 10:53 AM

View All 53 Files

Subscribers

Details

Reviewers

michal
kamil

Commits

rCOMMcc80ee8f7606: [lib][web][native] Start using lastCommunicatedPlatformDetailsSelector from…

Summary

issue: https://linear.app/comm/issue/ENG-4462/refactor-lastcommunicatedplatformdetails-field
The second step is to start using the lastCommunicatedPlatformDetails from the keyserverStore, instaed of the one at the top level of redux store

Test Plan

ran yarn flow-all. Checked all places where we use useSelector from react-redux, and checked that none of them selects lastCommunicatedPlatformDetails.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Sep 5 2023, 3:04 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 5 2023, 3:04 AM

inka added a child revision: D9078: [keyserver][lib][native][web] Remove lastCommunicatedPlatformDetails form redux top level.Sep 5 2023, 3:13 AM

Harbormaster completed remote builds in B22380: Diff 30747.Sep 5 2023, 3:21 AM

inka requested review of this revision.Sep 5 2023, 3:21 AM

inka added a parent revision: D9077: [keyserver][lib][native] Add lastCommunicatedPlatformDetails to keyserverStore.Sep 5 2023, 3:50 AM

michal accepted this revision.Sep 5 2023, 5:49 AM

This revision is now accepted and ready to land.Sep 5 2023, 5:49 AM

Closed by commit rCOMMcc80ee8f7606: [lib][web][native] Start using lastCommunicatedPlatformDetailsSelector from… (authored by inka). · Explain WhySep 5 2023, 7:20 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMMcc80ee8f7606: [lib][web][native] Start using lastCommunicatedPlatformDetailsSelector from….

Revision Contents
Changeset List

Path

Size

lib/

selectors/

keyserver-selectors.js

8 lines

server-calls.js

3 lines

native/

socket.react.js

3 lines

web/

socket.react.js

3 lines

Diff 30773

lib/selectors/keyserver-selectors.js

Loading...

lib/selectors/server-calls.js

Loading...

native/socket.react.js

Loading...

web/socket.react.js

Loading...