Paths

Table of Contentst

Differential D9060

[lib] Refactor lastCommunicatedPlatformDetails to be PlatformDetails
ClosedPublic
Actions

Authored by inka on Sep 1 2023, 2:24 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Jul 3, 3:05 PM

	Unknown Object (File)
	Wed, Jul 3, 8:30 AM

	Unknown Object (File)
	Fri, Jun 28, 3:34 PM

	Unknown Object (File)
	Mon, Jun 24, 8:15 AM

	Unknown Object (File)
	Sat, Jun 22, 11:43 PM

	Unknown Object (File)
	Fri, Jun 21, 1:16 AM

	Unknown Object (File)
	Tue, Jun 11, 5:26 PM

	Unknown Object (File)
	May 24 2024, 12:15 AM

View All 41 Files

Subscribers

Details

Reviewers

michal
kamil

Commits

rCOMM2eb888a53ee7: [lib] Refactor lastCommunicatedPlatformDetails to be PlatformDetails

Summary

issue: https://linear.app/comm/issue/ENG-4462/refactor-lastcommunicatedplatformdetails-field
I want to put lastCommunicatedPlatformDetails inside of keyserverStore. It will be much easier if lastCommunicatedPlatformDetails is first refatored to
be a single field of PlatformDetails type, mostly becuse the reducer will be possible to reuse in reduceKeyserverStore

Test Plan

ran yarn flow-all.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Sep 1 2023, 2:24 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 1 2023, 2:24 AM

inka added 1 blocking reviewer(s): michal.Sep 1 2023, 2:26 AM

inka added inline comments.Sep 1 2023, 2:28 AM

keyserver/src/responders/website-responders.js
608 ↗	(On Diff #30690)	Not sure if null or undefined makes more sense. Or maybe it would make more sense to type it as `lastCommunicatedPlatformDetails?: PlatformDetails`?

Harbormaster completed remote builds in B22338: Diff 30690.Sep 1 2023, 2:42 AM

inka requested review of this revision.Sep 1 2023, 2:42 AM

inka added a parent revision: D9062: [web] Start persisting keyserverStore.Sep 1 2023, 5:35 AM

michal accepted this revision.Sep 1 2023, 6:27 AM

michal added inline comments.

keyserver/src/responders/website-responders.js
608 ↗	(On Diff #30690)	We use `null` for missing fields already, so I think it makes sense.

This revision is now accepted and ready to land.Sep 1 2023, 6:27 AM

Fix lastCommunicatedPlatformDetails default validator

inka added a child revision: D9077: [keyserver][lib][native] Add lastCommunicatedPlatformDetails to keyserverStore.Sep 5 2023, 2:56 AM

Harbormaster completed remote builds in B22377: Diff 30744.Sep 5 2023, 3:05 AM

Closed by commit rCOMM2eb888a53ee7: [lib] Refactor lastCommunicatedPlatformDetails to be PlatformDetails (authored by inka). · Explain WhySep 5 2023, 7:20 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMM2eb888a53ee7: [lib] Refactor lastCommunicatedPlatformDetails to be PlatformDetails.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

responders/

website-responders.js

4 lines

lib/

reducers/

last-communicated-platform-details-reducer.js

17 lines

master-reducer.js

1 line

selectors/

server-calls.js

6 lines

socket/

socket.react.js

2 lines

types/

device-types.js

4 lines

9 lines

utils/

action-utils.js

6 lines

call-server-endpoint.js

15 lines

native/

redux/

2 lines

4 lines

socket.react.js

2 lines

web/

redux/

4 lines

socket.react.js

2 lines

Diff 30771

keyserver/src/responders/website-responders.js

Loading...

lib/reducers/last-communicated-platform-details-reducer.js

Loading...

lib/reducers/master-reducer.js

Loading...

lib/selectors/server-calls.js

Loading...

lib/socket/socket.react.js

Loading...

lib/types/device-types.js

Loading...

lib/types/redux-types.js

Loading...

lib/utils/action-utils.js

Loading...

lib/utils/call-server-endpoint.js

Loading...

native/redux/redux-setup.js

Loading...

native/redux/state-types.js

Loading...

native/socket.react.js

Loading...

web/redux/redux-setup.js

Loading...

web/socket.react.js

Loading...