Page MenuHomePhabricator

[lib] Refactor lastCommunicatedPlatformDetails to be PlatformDetails
ClosedPublic

Authored by inka on Sep 1 2023, 2:24 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 6, 7:08 AM
Unknown Object (File)
Thu, Oct 17, 11:11 AM
Unknown Object (File)
Thu, Oct 17, 11:11 AM
Unknown Object (File)
Thu, Oct 17, 11:11 AM
Unknown Object (File)
Thu, Oct 17, 11:11 AM
Unknown Object (File)
Thu, Oct 17, 11:08 AM
Unknown Object (File)
Fri, Oct 11, 6:43 AM
Unknown Object (File)
Oct 8 2024, 11:51 AM
Subscribers

Details

Summary

issue: https://linear.app/comm/issue/ENG-4462/refactor-lastcommunicatedplatformdetails-field
I want to put lastCommunicatedPlatformDetails inside of keyserverStore. It will be much easier if lastCommunicatedPlatformDetails is first refatored to
be a single field of PlatformDetails type, mostly becuse the reducer will be possible to reuse in reduceKeyserverStore

Test Plan

ran yarn flow-all.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

keyserver/src/responders/website-responders.js
608 ↗(On Diff #30690)

Not sure if null or undefined makes more sense. Or maybe it would make more sense to type it as lastCommunicatedPlatformDetails?: PlatformDetails?

inka requested review of this revision.Sep 1 2023, 2:42 AM
michal added inline comments.
keyserver/src/responders/website-responders.js
608 ↗(On Diff #30690)

We use null for missing fields already, so I think it makes sense.

This revision is now accepted and ready to land.Sep 1 2023, 6:27 AM

Fix lastCommunicatedPlatformDetails default validator