issue: https://linear.app/comm/issue/ENG-4462/refactor-lastcommunicatedplatformdetails-field
I want to put lastCommunicatedPlatformDetails inside of keyserverStore. It will be much easier if lastCommunicatedPlatformDetails is first refatored to
be a single field of PlatformDetails type, mostly becuse the reducer will be possible to reuse in reduceKeyserverStore
Details
Details
ran yarn flow-all.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
keyserver/src/responders/website-responders.js | ||
---|---|---|
608 ↗ | (On Diff #30690) | Not sure if null or undefined makes more sense. Or maybe it would make more sense to type it as lastCommunicatedPlatformDetails?: PlatformDetails? |
keyserver/src/responders/website-responders.js | ||
---|---|---|
608 ↗ | (On Diff #30690) | We use null for missing fields already, so I think it makes sense. |