Paths

Table of Contentst

Differential D9090

[native] make SingleLine the default export
ClosedPublic
Actions

Authored by ginsu on Sep 5 2023, 11:02 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Oct 22, 2:17 PM

	Unknown Object (File)
	Tue, Oct 22, 2:17 PM

	Unknown Object (File)
	Tue, Oct 22, 2:17 PM

	Unknown Object (File)
	Tue, Oct 22, 2:17 PM

	Unknown Object (File)
	Tue, Oct 22, 5:04 AM

	Unknown Object (File)
	Thu, Oct 10, 7:21 PM

	Unknown Object (File)
	Sep 22 2024, 6:27 PM

	Unknown Object (File)
	Sep 22 2024, 2:45 PM

View All 65 Files

Subscribers

Details

Reviewers

atul
inka

Commits

rCOMMfadafa9a0fc9: [native] make SingleLine the default export

Summary

While I was working with the SingleLine component for user profiles, I noticed that this component was not default export. This is not consistent with the rest of the components in our codebase, so to address this I made SingleLine the default export and updated the import calls to reflect this change

Depends on D9013

Test Plan

flow

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Sep 5 2023, 11:02 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 5 2023, 11:02 AM

ginsu edited the summary of this revision. (Show Details)Sep 5 2023, 11:04 AM

ginsu added reviewers: atul, inka.

ginsu added a parent revision: D9013: [native] clean up profile UI for users with long usernames.

Harbormaster completed remote builds in B22396: Diff 30786.Sep 5 2023, 11:20 AM

ginsu requested review of this revision.Sep 5 2023, 11:20 AM

Seems reasonable

This revision is now accepted and ready to land.Sep 6 2023, 2:02 PM

rebase before landing

Harbormaster completed remote builds in B22419: Diff 30818.Sep 6 2023, 2:55 PM

Closed by commit rCOMMfadafa9a0fc9: [native] make SingleLine the default export (authored by ginsu). · Explain WhySep 6 2023, 8:59 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMMfadafa9a0fc9: [native] make SingleLine the default export.

Revision Contents
Changeset List

Path

Size

native/

calendar/

2 lines

chat/

chat-input-bar.react.js

2 lines

chat-thread-list-item.react.js

2 lines

message-header.react.js

2 lines

message-preview.react.js

2 lines

settings/

thread-settings-home-notifs.react.js

2 lines

thread-settings-member.react.js

2 lines

thread-settings-name.react.js

2 lines

thread-settings-push-notifs.react.js

2 lines

sidebar-item.react.js

2 lines

subchannel-item.react.js

2 lines

timestamp.react.js

2 lines

components/

single-line.react.js

2 lines

thread-list-thread.react.js

2 lines

user-list-user.react.js

2 lines

user-profile.react.js

2 lines

invite-links/

view-invite-links-screen.react.js

2 lines

navigation/

community-drawer-item.react.js

2 lines

profile/

profile-screen.react.js

2 lines

relationship-list-item.react.js

2 lines

push/

in-app-notif.react.js

2 lines

tooltip/

tooltip-item.react.js

2 lines

Diff 30823

native/calendar/entry.react.js

Loading...

native/chat/chat-input-bar.react.js

Loading...

native/chat/chat-thread-list-item.react.js

Loading...

native/chat/message-header.react.js

Loading...

native/chat/message-preview.react.js

Loading...

native/chat/settings/thread-settings-home-notifs.react.js

Loading...

native/chat/settings/thread-settings-member.react.js

Loading...

native/chat/settings/thread-settings-name.react.js

Loading...

native/chat/settings/thread-settings-push-notifs.react.js

Loading...

native/chat/sidebar-item.react.js

Loading...

native/chat/subchannel-item.react.js

Loading...

native/chat/timestamp.react.js

Loading...

native/components/single-line.react.js

Loading...

native/components/thread-list-thread.react.js

Loading...

native/components/user-list-user.react.js

Loading...

native/components/user-profile.react.js

Loading...

native/invite-links/view-invite-links-screen.react.js

Loading...

native/navigation/community-drawer-item.react.js

Loading...

native/profile/profile-screen.react.js

Loading...

native/profile/relationship-list-item.react.js

Loading...

native/push/in-app-notif.react.js

Loading...

native/tooltip/tooltip-item.react.js

Loading...