Page MenuHomePhabricator

[native] memoize BottomSheetHandle
ClosedPublic

Authored by ginsu on Sep 12 2023, 8:56 AM.
Tags
None
Referenced Files
F3180209: D9150.diff
Fri, Nov 8, 4:22 AM
Unknown Object (File)
Tue, Nov 5, 12:55 AM
Unknown Object (File)
Sat, Oct 26, 1:28 AM
Unknown Object (File)
Sun, Oct 20, 3:41 PM
Unknown Object (File)
Sun, Oct 20, 3:41 PM
Unknown Object (File)
Sun, Oct 20, 3:41 PM
Unknown Object (File)
Sun, Oct 20, 3:41 PM
Unknown Object (File)
Sun, Oct 20, 3:41 PM
Subscribers

Details

Summary

In D8958 I should have memoized the bottom sheet handle component. This diff addresses that concern

Test Plan

confirmed that the handle still worked as expected

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu requested review of this revision.Sep 12 2023, 9:13 AM

Personal preference is memoization "inside" the component w/ useMemo hook so everything is self-contained and memoization is consistent and whatnot, but this is valid

This revision is now accepted and ready to land.Sep 12 2023, 1:34 PM
This revision was landed with ongoing or failed builds.Sep 12 2023, 2:05 PM
This revision was automatically updated to reflect the committed changes.