Page MenuHomePhabricator
Differential D9152

[native] Use expo-file-system uploads
ClosedPublic
Actions

Authored by • patryk on Sep 12 2023, 1:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 31, 1:14 PM
Unknown Object (File)
Thu, Oct 31, 1:14 PM
Unknown Object (File)
Thu, Oct 31, 1:14 PM
Unknown Object (File)
Thu, Oct 31, 1:14 PM
Unknown Object (File)
Sep 26 2024, 12:55 PM
Unknown Object (File)
Sep 26 2024, 12:55 PM
Unknown Object (File)
Sep 26 2024, 12:54 PM
Unknown Object (File)
Sep 10 2024, 12:07 PM
View All 72 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
atul
Commits
rCOMMb319ae976ea8: [native] Use expo-file-system uploads
Summary

This diff replaces react-native-background-upload to expo-file-system upload utilities.

Depends on D9151.

Test Plan
  1. Check if uploads work properly for unencrypted images:

1a. Check if image is uploaded when app is moved to background
1b. Check if image upload is canceled when abortHandler is executed

  1. Check above steps for encrypted images.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• patryk created this revision.Sep 12 2023, 1:43 PM
• patryk held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 12 2023, 1:43 PM
• patryk edited the summary of this revision. (Show Details)Sep 12 2023, 1:43 PM
• patryk added a parent revision: D9151: [native] Add expo-file-system dependency.
• patryk added a child revision: D9154: [lib] Add uuid dependency.Sep 12 2023, 1:45 PM
Harbormaster completed remote builds in B22540: Diff 30986.Sep 12 2023, 2:03 PM
• patryk edited the summary of this revision. (Show Details)Sep 13 2023, 2:40 AM
bartek added a comment.Sep 14 2023, 3:58 AM

code looks good, question regarding testing:

  • Have you tested it on both iOS and Android?
• patryk published this revision for review.Sep 14 2023, 4:45 AM

This code works properly on iOS, but I need to check if it is working properly on Android.

• patryk added a comment.Sep 21 2023, 2:05 AM

I've tested this diff on Android and it's working properly.

bartek accepted this revision.Sep 24 2023, 1:42 AM
This revision is now accepted and ready to land.Sep 24 2023, 1:42 AM
Closed by commit rCOMMb319ae976ea8: [native] Use expo-file-system uploads (authored by • patryk). · Explain WhySep 28 2023, 12:50 AM
This revision was automatically updated to reflect the committed changes.
• patryk added a commit: rCOMMb319ae976ea8: [native] Use expo-file-system uploads.
ashoat mentioned this in D9321: [native] Remove react-native-background-upload.Sep 28 2023, 10:17 AM
ashoat mentioned this in rCOMM905e10ddeb97: [native] Remove react-native-background-upload.Sep 29 2023, 7:45 AM

Revision Contents
Changeset List

PathSize
native/
input/
111 lines

Diff 30986

View Options

native/input/input-state-container.react.js

Loading...