[native] Extract default Redux state to separate file
ClosedPublic
Actions

Authored by ashoat on Sep 13 2023, 9:55 AM.

Details

Reviewers

tomek
michal

Commits

rCOMM3cf8825bf256: [native] Extract default Redux state to separate file

Summary

I want to import it from persist.js, but that would introduce a circular dependency since redux-setup.js already imports persist.js. The solution is to extract it to a separate file.

Test Plan

Flow
Confirmed that app starts correctly "from scratch" (no persisted Redux store)
Confirmed that app starts correctly from an existing Redux store

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Sep 13 2023, 9:55 AM

ashoat added a child revision: D9186: [native] Avoid crashing Redux migration if inviteLinksStore isn't initialized.Sep 13 2023, 10:00 AM

Harbormaster completed remote builds in B22599: Diff 31069.Sep 13 2023, 10:13 AM

ashoat requested review of this revision.Sep 13 2023, 10:13 AM

tomek accepted this revision.Sep 14 2023, 1:48 AM

This revision is now accepted and ready to land.Sep 14 2023, 1:48 AM

Closed by commit rCOMM3cf8825bf256: [native] Extract default Redux state to separate file (authored by ashoat). · Explain WhySep 14 2023, 6:04 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM3cf8825bf256: [native] Extract default Redux state to separate file.

Revision Contents
Changeset List

Path

Size

native/

redux/

default-state.js

90 lines

redux-setup.js

89 lines

Diff 31131

View Options

native/redux/default-state.js