Page MenuHomePhabricator

[web] introduce preferences settings in account settings
ClosedPublic

Authored by ginsu on Sep 13 2023, 2:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jun 11, 9:16 AM
Unknown Object (File)
Mon, Jun 10, 7:49 PM
Unknown Object (File)
Mon, Jun 10, 7:25 PM
Unknown Object (File)
May 6 2024, 6:13 AM
Unknown Object (File)
May 3 2024, 8:20 PM
Unknown Object (File)
May 1 2024, 5:31 PM
Unknown Object (File)
Apr 30 2024, 6:22 PM
Unknown Object (File)
Apr 28 2024, 4:51 PM

Details

Summary

This diff introduces the new apperance setting in the "My account" settings screen. This diff is just introducing the new elements to access this interface where we can easily toggle and test the new light mode

Please note that designs/UI here is not finalized. @ted still needs to do an official design pass for this, but since we are only showing this internally at the moment, I prioritized getting something "quick and dirty" out so @ted and I can start testing asap with the intention that we will polish this up down the line

Depends on D9194

Test Plan

Please see the screenshot below:

Screenshot 2023-09-13 at 5.00.37 PM.png (2×3 px, 880 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka, rohan.
ginsu added a subscriber: ted.
ginsu added inline comments.
web/settings/account-settings.react.js
64 ↗(On Diff #31097)

I will update this in a subsequent diff when I introduce the component

ginsu requested review of this revision.Sep 13 2023, 2:18 PM
rohan added inline comments.
web/settings/account-settings.css
68–70 ↗(On Diff #31097)

I know you're not focusing on the designs here, but just my own suggestion: this seems like a little too much padding in the screenshot you showed

This revision is now accepted and ready to land.Sep 14 2023, 7:40 AM
This revision was landed with ongoing or failed builds.Sep 14 2023, 8:29 AM
This revision was automatically updated to reflect the committed changes.