Page MenuHomePhabricator
Differential D9195

[web] introduce preferences settings in account settings
ClosedPublic
Actions

Authored by ginsu on Sep 13 2023, 2:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jul 16, 2:58 PM
Unknown Object (File)
Sat, Jul 6, 2:04 PM
Unknown Object (File)
Thu, Jul 4, 1:52 AM
Unknown Object (File)
Wed, Jul 3, 6:42 PM
Unknown Object (File)
Wed, Jul 3, 10:30 AM
Unknown Object (File)
Wed, Jul 3, 10:29 AM
Unknown Object (File)
Sun, Jun 30, 9:55 PM
Unknown Object (File)
Sun, Jun 30, 11:32 AM
View All 60 Files
Subscribers
ashoat
• ted
tomek

Details

Reviewers
atul
inka
rohan
Commits
rCOMMe14ab1b818cb: [web] introduce preferences settings in account settings
Summary

This diff introduces the new apperance setting in the "My account" settings screen. This diff is just introducing the new elements to access this interface where we can easily toggle and test the new light mode

Please note that designs/UI here is not finalized. @ted still needs to do an official design pass for this, but since we are only showing this internally at the moment, I prioritized getting something "quick and dirty" out so @ted and I can start testing asap with the intention that we will polish this up down the line

Depends on D9194

Test Plan

Please see the screenshot below:

Screenshot 2023-09-13 at 5.00.37 PM.png (2×3 px, 880 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Sep 13 2023, 2:00 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 13 2023, 2:00 PM
ginsu edited the summary of this revision. (Show Details)Sep 13 2023, 2:04 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka, rohan.
ginsu added a parent revision: D9194: [web] introduce useStaffCanSee hook for web.
ginsu attached a referenced file: F758190: Screenshot 2023-09-13 at 5.00.37 PM.png. (Show Details)
ginsu added a subscriber: • ted.
ginsu added inline comments.
web/settings/account-settings.react.js
64 ↗(On Diff #31097)

I will update this in a subsequent diff when I introduce the component

Harbormaster completed remote builds in B22618: Diff 31097.Sep 13 2023, 2:18 PM
ginsu requested review of this revision.Sep 13 2023, 2:18 PM
rohan accepted this revision.Sep 14 2023, 7:40 AM
rohan added inline comments.
web/settings/account-settings.css
68–70 ↗(On Diff #31097)

I know you're not focusing on the designs here, but just my own suggestion: this seems like a little too much padding in the screenshot you showed

This revision is now accepted and ready to land.Sep 14 2023, 7:40 AM
ginsu updated this revision to Diff 31139.Sep 14 2023, 8:24 AM

address feedback

This revision was landed with ongoing or failed builds.Sep 14 2023, 8:29 AM
Closed by commit rCOMMe14ab1b818cb: [web] introduce preferences settings in account settings (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMe14ab1b818cb: [web] introduce preferences settings in account settings.
Harbormaster completed remote builds in B22633: Diff 31139.Sep 14 2023, 8:43 AM

Revision Contents
Changeset List

PathSize
web/
settings/
11 lines
27 lines

Diff 31142

View Options

web/settings/account-settings.css

Loading...
View Options

web/settings/account-settings.react.js

Loading...