Page MenuHomePhabricator

[web] introduce AppearanceChangeModal
ClosedPublic

Authored by ginsu on Sep 14 2023, 9:05 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 17, 1:28 PM
Unknown Object (File)
Fri, May 10, 4:22 PM
Unknown Object (File)
Sun, May 5, 6:44 AM
Unknown Object (File)
Thu, May 2, 5:45 AM
Unknown Object (File)
Tue, Apr 30, 12:06 AM
Unknown Object (File)
Sun, Apr 28, 12:49 AM
Unknown Object (File)
Apr 25 2024, 4:02 PM
Unknown Object (File)
Apr 17 2024, 5:55 PM

Details

Summary

This diff introduces the AppearanceChangeModal component which will be used to toggle between light and dark mode for web.

Again I want to reiterate that the designs/UI here is not finalized. @ted still needs to do an official design pass for this, but since we are only showing this internally at the moment, I prioritized getting something "quick and dirty" out so @ted and I can start testing asap with the intention that we will polish this up down the line

Test Plan

Please see screenshot below

Screenshot 2023-09-14 at 12.05.28 PM.png (2×3 px, 819 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka, rohan.
ginsu added a subscriber: ted.
web/settings/appearance-change-modal.react.js
14 ↗(On Diff #31143)

This is temporary and will be replaced when I introduce the global theme redux states

ginsu requested review of this revision.Sep 14 2023, 9:23 AM
atul requested changes to this revision.Sep 17 2023, 3:04 PM
atul added inline comments.
web/settings/appearance-change-modal.react.js
38 ↗(On Diff #31143)

useCallback

44 ↗(On Diff #31143)

useCallback

This revision now requires changes to proceed.Sep 17 2023, 3:04 PM
ginsu edited the summary of this revision. (Show Details)

address @atul's feedback

web/settings/appearance-change-modal.react.js
14 ↗(On Diff #31237)

This is temporary and will be replaced when I introduce the global theme redux states

16–24 ↗(On Diff #31237)

I'm aware that this is not a very elegant solution here. Again want to reiterate that this is supposed to be "quick + dirty" and I anticipate that this is going to be updated after this experience goes through a design pass

This revision is now accepted and ready to land.Sep 20 2023, 1:50 PM
This revision was automatically updated to reflect the committed changes.