Page MenuHomePhabricator

[web] introduce AppearanceChangeModal

Authored by ginsu on Thu, Sep 14, 9:05 AM.
Referenced Files
F774777: D9203.diff
Tue, Sep 26, 11:41 AM
Unknown Object (File)
Sun, Sep 24, 10:04 PM
Unknown Object (File)
Fri, Sep 22, 9:29 PM
F759465: Screenshot 2023-09-14 at 12.05.28 PM.png
Thu, Sep 14, 9:07 AM



This diff introduces the AppearanceChangeModal component which will be used to toggle between light and dark mode for web.

Again I want to reiterate that the designs/UI here is not finalized. @ted still needs to do an official design pass for this, but since we are only showing this internally at the moment, I prioritized getting something "quick and dirty" out so @ted and I can start testing asap with the intention that we will polish this up down the line

Test Plan

Please see screenshot below

Screenshot 2023-09-14 at 12.05.28 PM.png (2×3 px, 819 KB)

Diff Detail

rCOMM Comm
No Lint Coverage
No Test Coverage

Event Timeline

ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka, rohan.
ginsu added a subscriber: ted.
14 ↗(On Diff #31143)

This is temporary and will be replaced when I introduce the global theme redux states

ginsu requested review of this revision.Thu, Sep 14, 9:23 AM
atul requested changes to this revision.Sun, Sep 17, 3:04 PM
atul added inline comments.
38 ↗(On Diff #31143)


44 ↗(On Diff #31143)


This revision now requires changes to proceed.Sun, Sep 17, 3:04 PM
ginsu edited the summary of this revision. (Show Details)

address @atul's feedback


This is temporary and will be replaced when I introduce the global theme redux states


I'm aware that this is not a very elegant solution here. Again want to reiterate that this is supposed to be "quick + dirty" and I anticipate that this is going to be updated after this experience goes through a design pass

This revision is now accepted and ready to land.Wed, Sep 20, 1:50 PM
This revision was automatically updated to reflect the committed changes.