Paths

Table of Contentst

[services-lib] Let blob client use services token
ClosedPublic
Actions

Authored by bartek on Sep 25 2023, 12:36 PM.

Details

Reviewers

michal
varun
• jon

Commits

rCOMM6a1036d0b610: [services-lib] Let blob client use services token

Summary

Changed blob client logic to use the new AuthorizationCredential enum instead of the more specific UserIdentity

Depends on D9243

Test Plan

Blob client works as before

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Sep 25 2023, 12:36 PM

bartek held this revision as a draft.

Herald added a reviewer: • jon. · View Herald TranscriptSep 25 2023, 12:36 PM

Herald added subscribers: tomek, ashoat. · View Herald Transcript

bartek added a child revision: D9276: [terraform] Add services token secret.Sep 25 2023, 12:38 PM

Harbormaster completed remote builds in B22814: Diff 31384.Sep 25 2023, 12:54 PM

bartek published this revision for review.Sep 25 2023, 12:56 PM

bartek added inline comments.

services/comm-services-lib/src/blob/client.rs
101–108 ↗	(On Diff #31384)	Maybe we should deprecate this function

michal accepted this revision.Sep 25 2023, 1:21 PM

michal added inline comments.

services/comm-services-lib/src/blob/client.rs
101–108 ↗	(On Diff #31384)	I don't have strong feelings about this, makes sense

This revision is now accepted and ready to land.Sep 25 2023, 1:21 PM

Closed by commit rCOMM6a1036d0b610: [services-lib] Let blob client use services token. · Explain WhyOct 2 2023, 1:27 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM6a1036d0b610: [services-lib] Let blob client use services token.

Revision Contents
Changeset List

Path

Size

services/

comm-services-lib/

src/

auth.rs

17 lines

blob/

client.rs

30 lines

Diff 31591

View Options

services/comm-services-lib/src/auth.rs