Page MenuHomePhabricator
Differential D9309

[native] introduce relationship button
ClosedPublic
Actions

Authored by ginsu on Sep 27 2023, 2:40 PM.
Tags
None
Referenced Files
F3366220: D9309.diff
Mon, Nov 25, 10:12 AM
Unknown Object (File)
Fri, Nov 22, 2:48 PM
Unknown Object (File)
Wed, Nov 20, 3:33 PM
Unknown Object (File)
Wed, Nov 13, 4:01 AM
Unknown Object (File)
Mon, Nov 4, 10:59 PM
Unknown Object (File)
Fri, Nov 1, 1:07 PM
Unknown Object (File)
Oct 26 2024, 1:27 AM
Unknown Object (File)
Oct 20 2024, 3:42 PM
View All 82 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
Commits
rCOMM3c4aa0915e83: [native] introduce relationship button
Summary

In D9258, I got some feedback to factor out some of the logic in UserProfileRelationshipButton into its own separate RelationshipButton component. This diff introduces this compnent and should address that feedback

Test Plan

Please see the screenshots below:

add:

Screenshot 2023-09-27 at 5.11.20 PM.png (1×948 px, 677 KB)

withdraw:

Screenshot 2023-09-27 at 5.11.29 PM.png (1×948 px, 686 KB)

accept & reject (there is a wrapping View for this in a parent component which is why it is in the row direction):

Screenshot 2023-09-27 at 5.47.12 PM.png (1×948 px, 448 KB)

block:

Screenshot 2023-09-27 at 5.11.04 PM.png (1×948 px, 678 KB)

unblock:

Screenshot 2023-09-27 at 5.11.10 PM.png (1×948 px, 678 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Sep 27 2023, 2:40 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 27 2023, 2:40 PM
ginsu added inline comments.Sep 27 2023, 2:42 PM
native/components/relationship-button.react.js
15–16 ↗(On Diff #31469)

Added block and unblock preemptively in case we ever wanted to use this component in those situations as well.

ginsu edited the test plan for this revision. (Show Details)Sep 27 2023, 2:50 PM
ginsu added reviewers: atul, inka.
ginsu edited the test plan for this revision. (Show Details)
ginsu attached a referenced file: F777606: Screenshot 2023-09-27 at 5.11.10 PM.png. (Show Details)
ginsu attached a referenced file: F777605: Screenshot 2023-09-27 at 5.11.04 PM.png. (Show Details)
ginsu attached a referenced file: F777600: Screenshot 2023-09-27 at 5.47.12 PM.png. (Show Details)
ginsu attached a referenced file: F777599: Screenshot 2023-09-27 at 5.11.29 PM.png. (Show Details)
ginsu attached a referenced file: F777598: Screenshot 2023-09-27 at 5.11.20 PM.png. (Show Details)
ginsu mentioned this in D9258: [native] introduce UserProfileRelationshipButton.Sep 27 2023, 2:58 PM
Harbormaster completed remote builds in B22880: Diff 31469.Sep 27 2023, 2:59 PM
ginsu requested review of this revision.Sep 27 2023, 2:59 PM
atul accepted this revision.Sep 27 2023, 4:28 PM
atul added inline comments.
native/components/relationship-button.react.js
15–16 ↗(On Diff #31469)

Love that it's flexible

This revision is now accepted and ready to land.Sep 27 2023, 4:28 PM
ginsu updated this revision to Diff 31475.Sep 27 2023, 10:34 PM

rebase before landing

Harbormaster completed remote builds in B22884: Diff 31475.Sep 27 2023, 10:53 PM
Closed by commit rCOMM3c4aa0915e83: [native] introduce relationship button (authored by ginsu). · Explain WhySep 27 2023, 11:02 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM3c4aa0915e83: [native] introduce relationship button.

Revision Contents
Changeset List

PathSize
native/
components/
94 lines

Diff 31479

View Options

native/components/relationship-button.react.js

Loading...