Page MenuHomePhabricator
Differential D9404

[web] Update `threadActivityStore[activeThread].lastNavigatedTo` state
ClosedPublic
Actions

Authored by atul on Oct 6 2023, 12:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 7:47 PM
Unknown Object (File)
Fri, Nov 29, 12:41 PM
Unknown Object (File)
Tue, Nov 26, 12:34 PM
Unknown Object (File)
Tue, Nov 26, 7:50 AM
Unknown Object (File)
Sun, Nov 24, 3:28 PM
Unknown Object (File)
Fri, Nov 22, 10:14 PM
Unknown Object (File)
Fri, Nov 22, 9:46 PM
Unknown Object (File)
Nov 13 2024, 7:29 PM
View All 65 Files
Subscribers
will

Details

Reviewers
ashoat
tomek
ginsu
Commits
rCOMM8a192aa280f0: [web] Update `threadActivityStore[activeThread].lastNavigatedTo` state
Summary

While the motivations for introducing threadActivityStore were about improving performance on native, we're making parallel changes to web for consistency.

Depends on D9402

Test Plan

Navigated to various threads and checked threadActivityStore updated as expected (this is safe to land, will introduce migrations that clean things up when ripping out lastNavigatedTo and lastPruned from messageStore.threads):

37af5f.png (228×774 px, 61 KB)

9da874.png (548×908 px, 74 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Oct 6 2023, 12:38 PM
Herald added a subscriber: will. · View Herald TranscriptOct 6 2023, 12:38 PM
atul published this revision for review.Oct 6 2023, 12:40 PM
atul edited the test plan for this revision. (Show Details)
atul added inline comments.
web/redux/redux-setup.js
331 ↗(On Diff #31755)

Removed this comment instead of updating it because I think it's pretty much paraphrasing the code below w/o pointing out anything novel/unintuitive/etc

Harbormaster completed remote builds in B23065: Diff 31755.Oct 6 2023, 12:56 PM
atul added a child revision: D9406: [lib] Handle `messageStorePruneActionType` in `reduceThreadActivity`.Oct 6 2023, 1:22 PM
ashoat accepted this revision.Oct 9 2023, 2:00 PM
This revision is now accepted and ready to land.Oct 9 2023, 2:00 PM
atul updated this revision to Diff 31838.Oct 9 2023, 2:15 PM

rebase and land

This revision was landed with ongoing or failed builds.Oct 9 2023, 2:16 PM
Closed by commit rCOMM8a192aa280f0: [web] Update `threadActivityStore[activeThread].lastNavigatedTo` state (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM8a192aa280f0: [web] Update `threadActivityStore[activeThread].lastNavigatedTo` state.
Harbormaster completed remote builds in B23131: Diff 31838.Oct 9 2023, 2:33 PM
will mentioned this in D11665: [web] convert updating thread activity `lastThreadNavigatedTo` on web to use sqlite.Apr 15 2024, 2:28 PM
will mentioned this in rCOMMd82518d49a1b: [web] convert updating thread activity `lastThreadNavigatedTo` on web to use….Apr 19 2024, 1:08 PM

Revision Contents
Changeset List

PathSize
web/
redux/
11 lines

Diff 31841

View Options

web/redux/redux-setup.js

Loading...