Paths

Table of Contentst

-
web/redux/
-
redux/
-
redux-setup.js

[web] Update `threadActivityStore[activeThread].lastNavigatedTo` state
ClosedPublic
Actions

Authored by atul on Oct 6 2023, 12:38 PM.

Details

Reviewers

ashoat
tomek
ginsu

Commits

rCOMM8a192aa280f0: [web] Update `threadActivityStore[activeThread].lastNavigatedTo` state

Summary

While the motivations for introducing threadActivityStore were about improving performance on native, we're making parallel changes to web for consistency.

Depends on D9402

Test Plan

Navigated to various threads and checked threadActivityStore updated as expected (this is safe to land, will introduce migrations that clean things up when ripping out lastNavigatedTo and lastPruned from messageStore.threads):

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Oct 6 2023, 12:38 PM

Herald added a subscriber: will. · View Herald TranscriptOct 6 2023, 12:38 PM

atul published this revision for review.Oct 6 2023, 12:40 PM

atul edited the test plan for this revision. (Show Details)

atul added inline comments.

web/redux/redux-setup.js
331 ↗	(On Diff #31755)	Removed this comment instead of updating it because I think it's pretty much paraphrasing the code below w/o pointing out anything novel/unintuitive/etc

Harbormaster completed remote builds in B23065: Diff 31755.Oct 6 2023, 12:56 PM

atul added a child revision: D9406: [lib] Handle `messageStorePruneActionType` in `reduceThreadActivity`.Oct 6 2023, 1:22 PM

ashoat accepted this revision.Oct 9 2023, 2:00 PM

This revision is now accepted and ready to land.Oct 9 2023, 2:00 PM

rebase and land

This revision was landed with ongoing or failed builds.Oct 9 2023, 2:16 PM

Closed by commit rCOMM8a192aa280f0: [web] Update `threadActivityStore[activeThread].lastNavigatedTo` state (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM8a192aa280f0: [web] Update `threadActivityStore[activeThread].lastNavigatedTo` state.

Harbormaster completed remote builds in B23131: Diff 31838.Oct 9 2023, 2:33 PM

will mentioned this in D11665: [web] convert updating thread activity `lastThreadNavigatedTo` on web to use sqlite.Apr 15 2024, 2:28 PM

will mentioned this in rCOMMd82518d49a1b: [web] convert updating thread activity `lastThreadNavigatedTo` on web to use….Apr 19 2024, 1:08 PM

Revision Contents
Changeset List

Path

Size

web/

redux/

redux-setup.js

11 lines

Diff 31841

View Options

web/redux/redux-setup.js

// @flow		// @flow

import AsyncStorage from '@react-native-async-storage/async-storage';		import AsyncStorage from '@react-native-async-storage/async-storage';
import invariant from 'invariant';		import invariant from 'invariant';
import { Platform } from 'react-native';		import { Platform } from 'react-native';
import Orientation from 'react-native-orientation-locker';		import Orientation from 'react-native-orientation-locker';
import { createMigrate, createTransform } from 'redux-persist';		import { createMigrate, createTransform } from 'redux-persist';
import type { Transform } from 'redux-persist/es/types.js';		import type { Transform } from 'redux-persist/es/types.js';

import { highestLocalIDSelector } from 'lib/selectors/local-id-selectors.js';		import { highestLocalIDSelector } from 'lib/selectors/local-id-selectors.js';
import { inconsistencyResponsesToReports } from 'lib/shared/report-utils.js';		import { inconsistencyResponsesToReports } from 'lib/shared/report-utils.js';
import {		import {
getContainingThreadID,		getContainingThreadID,
getCommunity,		getCommunity,
} from 'lib/shared/thread-utils.js';		} from 'lib/shared/thread-utils.js';
import {		import { DEPRECATED_unshimMessageStore } from 'lib/shared/unshim-utils.js';
DEPRECATED_unshimMessageStore,
unshimFunc,
} from 'lib/shared/unshim-utils.js';
import { defaultEnabledApps } from 'lib/types/enabled-apps.js';		import { defaultEnabledApps } from 'lib/types/enabled-apps.js';
import { defaultCalendarFilters } from 'lib/types/filter-types.js';		import { defaultCalendarFilters } from 'lib/types/filter-types.js';
import {		import {
type LocalMessageInfo,		type LocalMessageInfo,
type MessageStore,		type MessageStore,
messageTypes,		messageTypes,
type ClientDBMessageStoreOperation,		type ClientDBMessageStoreOperation,
type ClientDBMessageInfo,
} from 'lib/types/message-types.js';		} from 'lib/types/message-types.js';
import { defaultConnectionInfo } from 'lib/types/socket-types.js';		import { defaultConnectionInfo } from 'lib/types/socket-types.js';
import {		import { translateRawMessageInfoToClientDBMessageInfo } from 'lib/utils/message-ops-utils.js';
translateClientDBMessageInfoToRawMessageInfo,
translateRawMessageInfoToClientDBMessageInfo,
} from 'lib/utils/message-ops-utils.js';
import { defaultNotifPermissionAlertInfo } from 'lib/utils/push-alerts.js';		import { defaultNotifPermissionAlertInfo } from 'lib/utils/push-alerts.js';
import { convertThreadStoreOperationsToClientDBOperations } from 'lib/utils/thread-ops-utils.js';		import { convertThreadStoreOperationsToClientDBOperations } from 'lib/utils/thread-ops-utils.js';

import { migrateThreadStoreForEditThreadPermissions } from './edit-thread-permission-migration.js';		import { migrateThreadStoreForEditThreadPermissions } from './edit-thread-permission-migration.js';
import type { AppState } from './state-types.js';		import type { AppState } from './state-types.js';
		import { unshimClientDB } from './unshim-utils.js';
import { commCoreModule } from '../native-modules.js';		import { commCoreModule } from '../native-modules.js';
import { defaultDeviceCameraInfo } from '../types/camera.js';		import { defaultDeviceCameraInfo } from '../types/camera.js';
import { defaultGlobalThemeInfo } from '../types/themes.js';		import { defaultGlobalThemeInfo } from '../types/themes.js';
import { isTaskCancelledError } from '../utils/error-handling.js';		import { isTaskCancelledError } from '../utils/error-handling.js';

const migrations = {		const migrations = {
[1]: (state: AppState) => ({		[1]: (state: AppState) => ({
...state,		...state,
▲ Show 20 Lines • Show All 338 Lines • ▼ Show 20 Lines	try {
console.log(exception);		console.log(exception);
if (isTaskCancelledError(exception)) {		if (isTaskCancelledError(exception)) {
return state;		return state;
}		}
return { ...state, cookie: null };		return { ...state, cookie: null };
}		}
return state;		return state;
},		},
[32]: (state: AppState) => {		[32]: (state: AppState) => unshimClientDB(state, [messageTypes.MULTIMEDIA]),
// 1. Get messages from SQLite `messages` table.		[33]: (state: AppState) => unshimClientDB(state, [messageTypes.REACTION]),
const clientDBMessageInfos = commCoreModule.getAllMessagesSync();

// 2. Translate `ClientDBMessageInfo`s to `RawMessageInfo`s.
const rawMessageInfos = clientDBMessageInfos.map(
translateClientDBMessageInfoToRawMessageInfo,
);

// 3. "Unshim" translated `RawMessageInfo`s.
const unshimmedRawMessageInfos = rawMessageInfos.map(messageInfo =>
unshimFunc(messageInfo, new Set([messageTypes.MULTIMEDIA])),
);

// 4. Translate unshimmed `RawMessageInfo`s back to `ClientDBMessageInfo`s.
const unshimmedClientDBMessageInfos = unshimmedRawMessageInfos.map(
translateRawMessageInfoToClientDBMessageInfo,
);

// 5. Construct `ClientDBMessageStoreOperation`s to clear SQLite `messages`
// table and repopulate with unshimmed `ClientDBMessageInfo`s.
const operations: $ReadOnlyArray<ClientDBMessageStoreOperation> = [
{
type: 'remove_all',
},
...unshimmedClientDBMessageInfos.map((message: ClientDBMessageInfo) => ({
type: 'replace',
payload: message,
})),
];

// 6. Try processing `ClientDBMessageStoreOperation`s and log out if
// `processMessageStoreOperationsSync(...)` throws an exception.
try {
commCoreModule.processMessageStoreOperationsSync(operations);
} catch (exception) {
console.log(exception);
return { ...state, cookie: null };
}

return state;
},
[33]: (state: AppState) => {
// 1. Get messages from SQLite `messages` table.
const clientDBMessageInfos = commCoreModule.getAllMessagesSync();

// 2. Translate `ClientDBMessageInfo`s to `RawMessageInfo`s.
const rawMessageInfos = clientDBMessageInfos.map(
translateClientDBMessageInfoToRawMessageInfo,
);

// 3. "Unshim" translated `RawMessageInfo`s.
const unshimmedRawMessageInfos = rawMessageInfos.map(messageInfo =>
unshimFunc(messageInfo, new Set([messageTypes.REACTION])),
);

// 4. Translate unshimmed `RawMessageInfo`s back to `ClientDBMessageInfo`s.
const unshimmedClientDBMessageInfos = unshimmedRawMessageInfos.map(
translateRawMessageInfoToClientDBMessageInfo,
);

// 5. Construct `ClientDBMessageStoreOperation`s to clear SQLite `messages`
// table and repopulate with unshimmed `ClientDBMessageInfo`s.
const operations: $ReadOnlyArray<ClientDBMessageStoreOperation> = [
{
type: 'remove_all',
},
...unshimmedClientDBMessageInfos.map((message: ClientDBMessageInfo) => ({
type: 'replace',
payload: message,
})),
];

// 6. Try processing `ClientDBMessageStoreOperation`s and log out if
// `processMessageStoreOperationsSync(...)` throws an exception.
try {
commCoreModule.processMessageStoreOperationsSync(operations);
} catch (exception) {
console.log(exception);
return { ...state, cookie: null };
}

return state;
},
[34]: state => {		[34]: state => {
const { threadIDsToNotifIDs, ...stateSansThreadIDsToNotifIDs } = state;		const { threadIDsToNotifIDs, ...stateSansThreadIDsToNotifIDs } = state;
return stateSansThreadIDsToNotifIDs;		return stateSansThreadIDsToNotifIDs;
},		},
};		};

// After migration 31, we'll no longer want to persist `messageStore.messages`		// After migration 31, we'll no longer want to persist `messageStore.messages`
// via redux-persist. However, we DO want to continue persisting everything in		// via redux-persist. However, we DO want to continue persisting everything in
▲ Show 20 Lines • Show All 97 Lines • Show Last 20 Lines

[web] Update `threadActivityStore[activeThread].lastNavigatedTo` stateClosedPublicActions