Page MenuHomePhabricator

[web] Update `threadActivityStore[activeThread].lastNavigatedTo` state
ClosedPublic

Authored by atul on Oct 6 2023, 12:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 13, 7:29 PM
Unknown Object (File)
Sun, Nov 3, 9:46 PM
Unknown Object (File)
Mon, Oct 28, 8:17 PM
Unknown Object (File)
Fri, Oct 25, 1:15 AM
Unknown Object (File)
Oct 18 2024, 9:42 PM
Unknown Object (File)
Oct 18 2024, 9:42 PM
Unknown Object (File)
Oct 18 2024, 9:42 PM
Unknown Object (File)
Oct 2 2024, 6:00 AM
Subscribers

Details

Summary

While the motivations for introducing threadActivityStore were about improving performance on native, we're making parallel changes to web for consistency.


Depends on D9402

Test Plan

Navigated to various threads and checked threadActivityStore updated as expected (this is safe to land, will introduce migrations that clean things up when ripping out lastNavigatedTo and lastPruned from messageStore.threads):

37af5f.png (228×774 px, 61 KB)

9da874.png (548×908 px, 74 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul published this revision for review.Oct 6 2023, 12:40 PM
atul edited the test plan for this revision. (Show Details)
atul added inline comments.
web/redux/redux-setup.js
331 ↗(On Diff #31755)

Removed this comment instead of updating it because I think it's pretty much paraphrasing the code below w/o pointing out anything novel/unintuitive/etc

This revision is now accepted and ready to land.Oct 9 2023, 2:00 PM
This revision was landed with ongoing or failed builds.Oct 9 2023, 2:16 PM
This revision was automatically updated to reflect the committed changes.